Skip to content

CNV#36162: RN - NEW - Search option in VM configuration tab#71699

Merged
adellape merged 1 commit intoopenshift:enterprise-4.15from
danielclowers:CNV-36162
Feb 21, 2024
Merged

CNV#36162: RN - NEW - Search option in VM configuration tab#71699
adellape merged 1 commit intoopenshift:enterprise-4.15from
danielclowers:CNV-36162

Conversation

@danielclowers
Copy link
Contributor

@danielclowers danielclowers commented Feb 15, 2024 •
edited
Loading

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/CNV-36162

Link to docs preview:
https://71699--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-15-release-notes#virt-4-15-web

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 15, 2024 •
edited
Loading

🤖 Wed Feb 21 16:09:46 - Prow CI generated the docs preview: https://71699--ocpdocs-pr.netlify.app

gouyang
gouyang reviewed Feb 21, 2024
View reviewed changes
virt/release_notes/virt-4-15-release-notes.adoc Outdated
//CNV-36165: VM disks with persistent reservation

//CNV-36162: Search option in VM configuration tab
* A virtual machine's configuration section now has a search field.
Copy link

@gouyang gouyang Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is about adding a search field in the VM configuration tab, so user can find the configure filed easily by searching, could you rephase it a bit? :)

@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2024

@danielclowers: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danielclowers
Copy link
Contributor Author

danielclowers commented Feb 21, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 21, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented Feb 21, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 21, 2024
skopacz1
skopacz1 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skopacz1
Copy link
Contributor

skopacz1 commented Feb 21, 2024

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 21, 2024
@danielclowers
Copy link
Contributor Author

danielclowers commented Feb 21, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 21, 2024
@adellape adellape self-assigned this Feb 21, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 21, 2024
@adellape adellape merged commit ef33014 into openshift:enterprise-4.15 Feb 21, 2024
@adellape adellape added branch/enterprise-4.15 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 21, 2024
@adellape adellape added this to the Planned for 4.15 GA milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skopacz1 skopacz1 skopacz1 approved these changes

+1 more reviewer

@gouyang gouyang gouyang left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adellape adellape

Labels

branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.15 GA

Development

Successfully merging this pull request may close these issues.

5 participants

@danielclowers @ocpdocs-previewbot @skopacz1 @gouyang @adellape