Skip to content

OADP 3511 - removing OADP 1.1 Data Mover references#71790

Merged
bscott-rh merged 1 commit intoopenshift:mainfrom
CarmiWisemon:oadp3511-remove-datamover1-1
Feb 22, 2024
Merged

OADP 3511 - removing OADP 1.1 Data Mover references#71790
bscott-rh merged 1 commit intoopenshift:mainfrom
CarmiWisemon:oadp3511-remove-datamover1-1

Conversation

@CarmiWisemon
Copy link
Contributor

@CarmiWisemon CarmiWisemon commented Feb 18, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 18, 2024 •
edited
Loading

🤖 Thu Feb 22 10:16:38 - Prow CI generated the docs preview: https://71790--ocpdocs-pr.netlify.app

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2024
@CarmiWisemon CarmiWisemon force-pushed the oadp3511-remove-datamover1-1 branch from e7a9fd5 to a3d93bf Compare February 20, 2024 11:30
amastbau
amastbau reviewed Feb 20, 2024
View reviewed changes
amastbau
amastbau reviewed Feb 20, 2024
View reviewed changes
@amastbau
Copy link

amastbau commented Feb 20, 2024

LGTMed

@CarmiWisemon CarmiWisemon force-pushed the oadp3511-remove-datamover1-1 branch from 0c3c13c to 2a04804 Compare February 21, 2024 08:05
@CarmiWisemon
Copy link
Contributor Author

CarmiWisemon commented Feb 21, 2024

/label OADP
/label peer-review-needed

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 21, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented Feb 21, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 21, 2024
skopacz1
skopacz1 reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but otherwise LGTM!

@skopacz1
Copy link
Contributor

skopacz1 commented Feb 21, 2024

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 21, 2024
@CarmiWisemon CarmiWisemon force-pushed the oadp3511-remove-datamover1-1 branch from 2a04804 to d289f24 Compare February 22, 2024 08:56
@CarmiWisemon CarmiWisemon force-pushed the oadp3511-remove-datamover1-1 branch from 26e2b41 to 62189e9 Compare February 22, 2024 10:09
@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2024

@CarmiWisemon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CarmiWisemon
Copy link
Contributor Author

CarmiWisemon commented Feb 22, 2024

@skopacz1
Thank you for your helpful suggestions and feedback.

@CarmiWisemon
Copy link
Contributor Author

CarmiWisemon commented Feb 22, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 22, 2024
@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 22, 2024
@bscott-rh bscott-rh added this to the Continuous Release milestone Feb 22, 2024
@bscott-rh bscott-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 22, 2024
@bscott-rh
Copy link
Contributor

bscott-rh commented Feb 22, 2024

Merge review LGTM.

@bscott-rh bscott-rh merged commit a65db76 into openshift:main Feb 22, 2024
@bscott-rh
Copy link
Contributor

bscott-rh commented Feb 22, 2024

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 22, 2024

@bscott-rh: new pull request created: #72031

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

bscott-rh commented Feb 22, 2024

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 22, 2024

@bscott-rh: new pull request created: #72032

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

bscott-rh commented Feb 22, 2024

/cherrypick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 22, 2024

@bscott-rh: new pull request created: #72033

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skopacz1 skopacz1 skopacz1 left review comments

+1 more reviewer

@amastbau amastbau amastbau left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@CarmiWisemon @ocpdocs-previewbot @amastbau @skopacz1 @bscott-rh @openshift-cherrypick-robot