Skip to content

#CNV-34697 - GA instance types rn#71929

Merged
jldohmann merged 1 commit intoopenshift:enterprise-4.15from
sabrinajess:CNV34697
Feb 22, 2024
Merged

#CNV-34697 - GA instance types rn#71929
jldohmann merged 1 commit intoopenshift:enterprise-4.15from
sabrinajess:CNV34697

Conversation

@sabrinajess
Copy link
Contributor

@sabrinajess sabrinajess commented Feb 20, 2024

Version(s): 4.15 RN

Issue: CNV-34697

Link to docs preview: https://71929--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-15-release-notes#virt-4-15-web

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 20, 2024

🤖 Thu Feb 22 11:37:03 - Prow CI generated the docs preview: https://71929--ocpdocs-pr.netlify.app

@sabrinajess
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 20, 2024
@skopacz1
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 20, 2024
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit/suggestion, otherwise LGTM!

@skopacz1
Copy link
Contributor

/label peer-review-in-progress

@skopacz1
Copy link
Contributor

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 20, 2024
@gouyang
Copy link

gouyang commented Feb 20, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2024

New changes are detected. LGTM label has been removed.

@sabrinajess
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 21, 2024
@adellape adellape self-assigned this Feb 21, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 21, 2024
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to hold for some formatting fixes. Please re-queue for merge-review after comment is addressed. Thank you!

Edit: Looks like the PR needs rebasing too anyway.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 21, 2024
@adellape adellape added this to the Planned for 4.15 GA milestone Feb 21, 2024
@openshift-ci openshift-ci bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2024

@sabrinajess: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sabrinajess
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 22, 2024
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 22, 2024
@jldohmann jldohmann merged commit 5dc354b into openshift:enterprise-4.15 Feb 22, 2024
@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants