Skip to content

ocpbugs16964: adding control plane label note#73264

Merged
mburke5678 merged 1 commit intoopenshift:mainfrom
DCChadwick:ocpbugs16964
Apr 5, 2024
Merged

ocpbugs16964: adding control plane label note#73264
mburke5678 merged 1 commit intoopenshift:mainfrom
DCChadwick:ocpbugs16964

Conversation

@DCChadwick
Copy link

@DCChadwick DCChadwick commented Mar 15, 2024 •
edited
Loading

Version(s): 4.12+

Issue: OCPBUGS-16964

Link to docs preview: https://73264--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/nodes/nodes-nodes-viewing.html#nodes-nodes-viewing-listing_nodes-nodes-viewing

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 15, 2024 •
edited
Loading

🤖 Fri Apr 05 19:14:40 - Prow CI generated the docs preview:

https://73264--ocpdocs-pr.netlify.app/
https://73264--ocpdocs-pr.netlify.app/openshift-dedicated/latest/nodes/nodes/nodes-nodes-viewing.html
https://73264--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/nodes/nodes-nodes-viewing.html
https://73264--ocpdocs-pr.netlify.app/openshift-rosa/latest/nodes/nodes/nodes-nodes-viewing.html

@DCChadwick DCChadwick force-pushed the ocpbugs16964 branch 2 times, most recently from cf40caa to 8b27ef4 Compare March 18, 2024 19:08
@DCChadwick
Copy link
Author

DCChadwick commented Mar 18, 2024

@sunilcio This PR is ready for QE review.

@sunilcio
Copy link

sunilcio commented Mar 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@DCChadwick
Copy link
Author

DCChadwick commented Mar 28, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 28, 2024
@GroceryBoyJr
Copy link
Contributor

GroceryBoyJr commented Mar 28, 2024

/label peer-review-done
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 28, 2024
GroceryBoyJr
GroceryBoyJr reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DCChadwick
Copy link
Author

DCChadwick commented Mar 28, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 28, 2024
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 28, 2024
@stevsmit stevsmit added this to the Continuous Release milestone Mar 28, 2024
stevsmit
stevsmit reviewed Mar 28, 2024
View reviewed changes
@stevsmit stevsmit removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 28, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@openshift-ci
Copy link

openshift-ci bot commented Apr 2, 2024

New changes are detected. LGTM label has been removed.

@DCChadwick
Copy link
Author

DCChadwick commented Apr 2, 2024

/retest

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2024
@DCChadwick DCChadwick force-pushed the ocpbugs16964 branch 5 times, most recently from c8b81b5 to be163b9 Compare April 5, 2024 17:58
@DCChadwick
Copy link
Author

DCChadwick commented Apr 5, 2024

/label merge-review-needed

mburke5678
mburke5678 reviewed Apr 5, 2024
View reviewed changes
mburke5678
mburke5678 reviewed Apr 5, 2024
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2024

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mburke5678 mburke5678 merged commit 68e5102 into openshift:main Apr 5, 2024
@mburke5678
Copy link
Contributor

mburke5678 commented Apr 5, 2024

/cherrypick enterprise-4.12

@mburke5678
Copy link
Contributor

mburke5678 commented Apr 5, 2024

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor

mburke5678 commented Apr 5, 2024

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

mburke5678 commented Apr 5, 2024

/cherrypick enterprise-4.15

@mburke5678
Copy link
Contributor

mburke5678 commented Apr 5, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 5, 2024

@mburke5678: new pull request created: #74304

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 5, 2024

@mburke5678: new pull request created: #74305

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 5, 2024

@mburke5678: new pull request created: #74306

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 5, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 5, 2024

@mburke5678: new pull request created: #74307

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 5, 2024

@mburke5678: new pull request created: #74308

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@aireilly aireilly aireilly left review comments

@stevsmit stevsmit stevsmit left review comments

+2 more reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sunilcio sunilcio

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@DCChadwick @ocpdocs-previewbot @sunilcio @GroceryBoyJr @mburke5678 @openshift-cherrypick-robot @aireilly @stevsmit @ocpdocs-vale-bot