Skip to content

CNV#39982: Cloning VMs assembly#73715

Merged
ousleyp merged 1 commit intoopenshift:mainfrom
ousleyp:vm-from-snapshot
Mar 29, 2024
Merged

CNV#39982: Cloning VMs assembly#73715
ousleyp merged 1 commit intoopenshift:mainfrom
ousleyp:vm-from-snapshot

Conversation

@ousleyp
Copy link
Member

@ousleyp ousleyp commented Mar 25, 2024

Version(s): 4.14+

Issue: CNV-39982

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: My main intention for this PR is to create a straightforward "Cloning VMs" assembly to house the cloning-related modules that I am moving out of the instance types documentation.

I considered adding the "About cloning" module to this new assembly, but it might not be relevant unless we add docs for a more technical audience to this page (CLI-based cloning procedures?).

@ousleyp ousleyp added this to the Continuous Release milestone Mar 25, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2024

🤖 Tue Mar 26 15:04:14 - Prow CI generated the docs preview:
https://73715--ocpdocs-pr.netlify.app

@ousleyp ousleyp force-pushed the vm-from-snapshot branch 2 times, most recently from f57901e to 2500867 Compare March 25, 2024 21:49
@ousleyp ousleyp requested a review from jpeimer March 25, 2024 22:18
@ousleyp ousleyp changed the title JiraTBD: Clarifying cloning docs CNV#39982: Clarifying cloning docs Mar 25, 2024
@ousleyp ousleyp added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 25, 2024
@ousleyp ousleyp changed the title CNV#39982: Clarifying cloning docs CNV#39982: Cloning VMs assembly Mar 25, 2024
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 26, 2024
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and a suggestion, rest LGTM!
You might also want to consider getting it QE reviewed.

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 26, 2024
@ousleyp
Copy link
Member Author

ousleyp commented Mar 26, 2024

One comment and a suggestion, rest LGTM! You might also want to consider getting it QE reviewed.

Thanks so much, @snarayan-redhat ! I'm waiting on QE and won't merge until I have QE approval. :)

@openshift-ci
Copy link

openshift-ci bot commented Mar 26, 2024

@ousleyp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@jpeimer jpeimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you Pan

@ousleyp ousleyp merged commit 9aecf32 into openshift:main Mar 29, 2024
@ousleyp
Copy link
Member Author

ousleyp commented Mar 29, 2024

/cherrypick enterprise-4.16

@ousleyp
Copy link
Member Author

ousleyp commented Mar 29, 2024

/cherrypick enterprise-4.15

@ousleyp
Copy link
Member Author

ousleyp commented Mar 29, 2024

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@ousleyp: new pull request created: #73950

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ousleyp: new pull request created: #73951

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 branch/enterprise-4.16 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants