Skip to content

OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc#74066

Merged
opayne1 merged 1 commit intoopenshift:mainfrom
gwynnemonahan:OSSM-6247
Apr 2, 2024
Merged

OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc#74066
opayne1 merged 1 commit intoopenshift:mainfrom
gwynnemonahan:OSSM-6247

Conversation

@gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Apr 2, 2024

OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSSM-6247

Link to docs preview:
N/A

QE review:
QE review is not needed for this PR.

Additional information:
Adds 3 attributes under //service mesh v2:

:KialiProduct: Kiali Operator provided by Red Hat
:SMPlugin: OpenShift Service Mesh Console (OSSMC) plugin
:SMPluginShort: OSSMC plugin

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2024
@ocpdocs-previewbot
Copy link

🤖 Tue Apr 02 17:06:20 - Prow CI generated the docs preview:
https://74066--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci
Copy link

openshift-ci bot commented Apr 2, 2024

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 2, 2024
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 2, 2024
@mburke5678
Copy link
Contributor

@gwynnemonahan The format of the attributes LGTM

@mburke5678 mburke5678 added branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 2, 2024
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 2, 2024
@opayne1 opayne1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 2, 2024
@opayne1 opayne1 added this to the Continuous Release milestone Apr 2, 2024
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@opayne1 opayne1 merged commit 47200f9 into openshift:main Apr 2, 2024
@opayne1
Copy link
Contributor

opayne1 commented Apr 2, 2024

/cherrypick enterprise-4.12

@opayne1
Copy link
Contributor

opayne1 commented Apr 2, 2024

/cherrypick enterprise-4.13

@opayne1
Copy link
Contributor

opayne1 commented Apr 2, 2024

/cherrypick enterprise-4.14

@opayne1
Copy link
Contributor

opayne1 commented Apr 2, 2024

/cherrypick enterprise-4.15

@opayne1
Copy link
Contributor

opayne1 commented Apr 2, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@opayne1: #74066 failed to apply on top of branch "enterprise-4.12":

Applying: OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
Falling back to patching base and 3-way merge...
Auto-merging _attributes/common-attributes.adoc
CONFLICT (content): Merge conflict in _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@opayne1: #74066 failed to apply on top of branch "enterprise-4.13":

Applying: OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
Falling back to patching base and 3-way merge...
Auto-merging _attributes/common-attributes.adoc
CONFLICT (content): Merge conflict in _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@opayne1: #74066 failed to apply on top of branch "enterprise-4.14":

Applying: OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
Falling back to patching base and 3-way merge...
Auto-merging _attributes/common-attributes.adoc
CONFLICT (content): Merge conflict in _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSSM-6247 Add Kiali and OSSMC plugin attributes to common-attributes.adoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@opayne1: new pull request created: #74091

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@opayne1: new pull request created: #74092

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@opayne1
Copy link
Contributor

opayne1 commented Apr 2, 2024

@gwynnemonahan looks like you will need to do a manual CP for 4.12-4.14

@gwynnemonahan
Copy link
Contributor Author

@opayne1 Wait...so the common-attributes file doesn't exist on 4.12, 4.13, or 4.14?

@opayne1
Copy link
Contributor

opayne1 commented Apr 2, 2024

It exists there is just a conflict on the lines you are trying to add to in those branches.

@libander
Copy link
Contributor

libander commented Apr 2, 2024

Manual CPs:
4.12: #74093
4.13: #74094
4.14: #74095

opayne1 added a commit that referenced this pull request Apr 2, 2024
opayne1 added a commit that referenced this pull request Apr 2, 2024
opayne1 added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants