Skip to content

To remove TP statements from IPI and CSI Driver documentation#74134

Merged
skrthomas merged 1 commit intoopenshift:mainfrom
alishaIBM:ibmp_remove_tp
Apr 8, 2024
Merged

To remove TP statements from IPI and CSI Driver documentation#74134
skrthomas merged 1 commit intoopenshift:mainfrom
alishaIBM:ibmp_remove_tp

Conversation

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 3, 2024
@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2024

@alishaIBM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alishaIBM
Copy link
Contributor Author

/assign @manojnkumar @mjturek

@mjturek
Copy link
Contributor

mjturek commented Apr 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@manojnkumar
Copy link

LGTM

@alishaIBM
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 5, 2024
@opayne1 opayne1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 5, 2024
@opayne1 opayne1 added this to the Continuous Release milestone Apr 5, 2024
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. This would still need a QE review before merging if you have not obtained that yet.

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 5, 2024
@alishaIBM
Copy link
Contributor Author

looks good to me. This would still need a QE review before merging if you have not obtained that yet.

We have the QE approval above for this change.

@alishaIBM
Copy link
Contributor Author

@davemulford
Copy link

LGTM

@xltian
Copy link

xltian commented Apr 8, 2024

/lgtm

@jrthms
Copy link

jrthms commented Apr 8, 2024

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2024

@jrthms: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alishaIBM
Copy link
Contributor Author

@sjstout approved changes over slack

@alishaIBM
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 8, 2024
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 8, 2024
@skrthomas skrthomas merged commit 77ecdf0 into openshift:main Apr 8, 2024
@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.15

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@skrthomas: new pull request created: #74376

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@skrthomas: new pull request created: #74377

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants