Skip to content

OSDOCS#7763: Updating OSD documentation to be cloud agnostic or have GCP references included#75001

Merged
EricPonvelle merged 1 commit intoopenshift:mainfrom
eohartman:osdocs-7763-2
May 17, 2024
Merged

OSDOCS#7763: Updating OSD documentation to be cloud agnostic or have GCP references included#75001
EricPonvelle merged 1 commit intoopenshift:mainfrom
eohartman:osdocs-7763-2

Conversation

@eohartman
Copy link
Contributor

@eohartman eohartman commented Apr 22, 2024

Issue:
OSDOCS-7763

Version:
4.15+

Link to docs preview:

  1. General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
  2. Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
  3. Using bound service account tokens - Added GCP IAM to first paragraph.
  4. Example trigger authentication with pod authentication providers - Added 'gcp-gke' value to 3 Specifies a pod identity.
  5. Log output types - added cloudlogging into the Output type descriptions section.
  6. Enabling stream-based retention for Loki - Added two examples - Example global stream-based retention for GCP and Example per-tenant stream-based retention for GCP.
  7. Cloudwatch recommendation for OpenShift Dedicated - Removed "Cloudwatch recommendation for OpenShift Dedicated section.

The following have a note added above the example:

  1. oc adm release extract - Added note before the example.
  2. oc image mirror - Added note before the example.
  3. Showing data collected by Telemetry - Added note before the example.
  4. Understanding how to use pod disruption budgets to specify the number of pods that must be up - Added note before the example.

Note: Before and after images are attached to OSDOCS-7763 for ease of viewing.

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 22, 2024

🤖 Thu May 16 22:13:19 - Prow CI generated the docs preview:
https://75001--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:
General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:
General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
Using bound service account tokens - Added GCP IAM to first paragraph.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:
General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
Using bound service account tokens - Added GCP IAM to first paragraph.
Scope of the network reply - The last bullet point now includes OCP reference and link, as well.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eohartman eohartman force-pushed the osdocs-7763-2 branch 3 times, most recently from 26f8198 to da4825d Compare April 23, 2024 21:32
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:
General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
Using bound service account tokens - Added GCP IAM to first paragraph.
Scope of the network reply - The last bullet point now includes OCP reference and link, as well.
oc adm release extract - Added note before the example.
oc image mirror - Added note before the example.
Showing data collected by Telemetry

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:
General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
Using bound service account tokens - Added GCP IAM to first paragraph.
Scope of the network reply - The last bullet point now includes OCP reference and link, as well.
oc adm release extract - Added note before the example.
oc image mirror - Added note before the example.
Showing data collected by Telemetry - Added note before the example.
Understanding how to use pod disruption budgets to specify the number of pods that must be up - Added note before the example.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eohartman eohartman force-pushed the osdocs-7763-2 branch 2 times, most recently from be0c90e to b6aee40 Compare April 23, 2024 21:51
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:

  1. General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
  2. Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
  3. Using bound service account tokens - Added GCP IAM to first paragraph.
  4. Scope of the network reply - The last bullet point now includes OCP reference and link, as well.

The following have a note added above the example:

  1. oc adm release extract - Added note before the example.
  2. oc image mirror - Added note before the example.
  3. Showing data collected by Telemetry - Added note before the example.
  4. Understanding how to use pod disruption budgets to specify the number of pods that must be up - Added note before the example.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:

  1. General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
  2. Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
  3. Using bound service account tokens - Added GCP IAM to first paragraph.
  4. Scope of the network reply - The last bullet point now includes OCP reference and link, as well.

The following have a note added above the example:

  1. oc adm release extract - Added note before the example.
  2. oc image mirror - Added note before the example.
  3. Showing data collected by Telemetry - Added note before the example.
  4. Understanding how to use pod disruption budgets to specify the number of pods that must be up - Added note before the example.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:

  1. General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
  2. Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
  3. Using bound service account tokens - Added GCP IAM to first paragraph.
  4. Scope of the network reply - The last bullet point now includes OCP reference and link, as well.
  5. Example trigger authentication with pod authentication providers - Added 'gcp-gke' value to 3 Specifies a pod identity.

The following have a note added above the example:

  1. oc adm release extract - Added note before the example.
  2. oc image mirror - Added note before the example.
  3. Showing data collected by Telemetry - Added note before the example.
  4. Understanding how to use pod disruption budgets to specify the number of pods that must be up - Added note before the example.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eohartman eohartman force-pushed the osdocs-7763-2 branch 2 times, most recently from bd48bce to 88716eb Compare April 23, 2024 22:20
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:

  1. General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
  2. Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
  3. Using bound service account tokens - Added GCP IAM to first paragraph.
  4. Scope of the network verification checks - The last bullet point now includes OCP reference and link, as well.
  5. Example trigger authentication with pod authentication providers - Added 'gcp-gke' value to 3 Specifies a pod identity.

The following have a note added above the example:

  1. oc adm release extract - Added note before the example.
  2. oc image mirror - Added note before the example.
  3. Showing data collected by Telemetry - Added note before the example.
  4. Understanding how to use pod disruption budgets to specify the number of pods that must be up - Added note before the example.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2024

@eohartman: This pull request references OSDOCS-7763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7763

Link to docs preview:

  1. General settings table: Balancing-ignored-labels setting uses row - This no longer references AWS.
  2. Information collected by the Insights Operator - The fifth bullet point no longer mentions AWS. Additionally, removed a period from another bullet point so they're all consistent.
  3. Using bound service account tokens - Added GCP IAM to first paragraph.
  4. Scope of the network verification checks - The last bullet point now includes OCP reference and link, as well.
  5. Example trigger authentication with pod authentication providers - Added 'gcp-gke' value to 3 Specifies a pod identity.
  6. Log output types - added cloudlogging into the Output type descriptions table.

The following have a note added above the example:

  1. oc adm release extract - Added note before the example.
  2. oc image mirror - Added note before the example.
  3. Showing data collected by Telemetry - Added note before the example.
  4. Understanding how to use pod disruption budgets to specify the number of pods that must be up - Added note before the example.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 9, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2024
@eohartman
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2024

@eohartman: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anpingli
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@EricPonvelle EricPonvelle merged commit a346ed7 into openshift:main May 17, 2024
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.15

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #76204

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #76205

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.