Skip to content

cGroup v1 is deprecated in 4.16#75120

Merged
mburke5678 merged 1 commit intoopenshift:mainfrom
mburke5678:node-cgroup-v1-deprecation
May 21, 2024
Merged

cGroup v1 is deprecated in 4.16#75120
mburke5678 merged 1 commit intoopenshift:mainfrom
mburke5678:node-cgroup-v1-deprecation

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Apr 24, 2024

https://issues.redhat.com/browse/OSDOCS-10339

Add deprecation snippet to various docs.

Enabling Linux control group version 1 (cgroup v1) -- Important note after first paragraph.
Preparing to install a cluster that uses SR-IOV -- Important note after second paragraph.
Tuning nodes for low latency with the performance profile -- Not sure this module is being used.
Enabling Linux control group version 1 (cgroup v1) -- Important note after second bullet
Configuring the Linux cgroup version on your nodes -- Important note after first paragraph
Nodes -> Working with nodes -> Managing nodes -> Adding kernel arguments to nodes -- Important note after second bullet
OCP: Adding kernel arguments to nodes -- Important note after second bullet
OKD: Adding kernel arguments to nodes -- Important note after second bullet
Telco: Reference design specifications -> Telco reference design specifications -> RAN DU reference design configuration CRs -- Important Note after table.
Telco -> RAN DU ref design components -> Node Tuning Operator -- Important note after Engineering consideratiuons list
OCP: Configuring Linux cgroup -- Important note after third paragraph
OKD: Configuring Linux cgroup -- Important note after third paragraph

QE review:

  • QE has approved this change.

@mburke5678 mburke5678 added this to the Planned for 4.16 GA milestone Apr 24, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@mburke5678 mburke5678 force-pushed the node-cgroup-v1-deprecation branch from ad36f1e to e491d30 Compare May 10, 2024 15:04
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@mburke5678
Copy link
Contributor Author

Kevin Quinn (CNF)

@mburke5678
Copy link
Contributor Author

@gauravsingh85 @control-d PTAL

@gauravsingh85
Copy link

LGTM

@mburke5678 mburke5678 force-pushed the node-cgroup-v1-deprecation branch from 51dd876 to 7a2ce83 Compare May 13, 2024 19:55
@mburke5678
Copy link
Contributor Author

@gauravsingh85 Thank you for the quick review. Do you have any thoughts on who would be an appropriate QE resource to review?

@control-d
Copy link

LGTM

1 similar comment
@gauravsingh85
Copy link

LGTM

@sunilcio
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@mburke5678 mburke5678 force-pushed the node-cgroup-v1-deprecation branch from 7a2ce83 to f491a79 Compare May 20, 2024 20:07
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label May 20, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 20, 2024

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 20, 2024
@mletalie
Copy link
Contributor

Hello @mburke5678,
This may be a result of our mod docs structure, but within this topic do we need to have this note duplicated here: https://75120--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/enabling-cgroup-v1.html
image

@mletalie
Copy link
Contributor

A couple of observations/comments:

  • I see the preview link Tuning nodes for low latency with the performance profile is directed to the module within the PR and not a doc preview, which makes sense given your comment about that link. Just wanted to mention as this may be a YTBD decision.

  • Looking at the rest of the doc previews, I see other examples like the one I mentioned above (the "Important" call-out in close proximity to one another), and understand the need to do so as a result of how we structure docs, so while it may have been worth mentioning, don't think much can be done about it.

  • In the note itself, it seems that the words "feature" and functionality" are used interchangeably. Would it be worth it to phrase the call-out so it is consistent throughout? May not matter/make a difference but wanted to mention.

Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-done
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/lgtm

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label May 21, 2024
@openshift-ci openshift-ci bot removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 21, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@mburke5678
Copy link
Contributor Author

In the note itself, it seems that the words "feature" and functionality" are used interchangeably. Would it be worth it to phrase the call-out so it is consistent throughout? May not matter/make a difference but wanted to mention.

@mletalie That is a good point. Not sure who is responsible for the boilerplate language, though.

@mburke5678
Copy link
Contributor Author

I see the preview link Tuning nodes for low latency with the performance profile is directed to the module within the PR and not a doc preview, which makes sense given your comment about that link. Just wanted to mention as this may be a YTBD decision.
Sorry for the confusion, Mark. I added the link to the file with the note that the module might not be in use so that you didn't think I forgot to add the preview.

@mburke5678 mburke5678 merged commit 8043812 into openshift:main May 21, 2024
@mburke5678 mburke5678 deleted the node-cgroup-v1-deprecation branch May 21, 2024 15:12
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@mburke5678: new pull request created: #76300

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants