Skip to content

HCIDOCS-189: Add note with link to OCP docs about exposed CoreDNS port#75740

Merged
bscott-rh merged 1 commit intoopenshift:mainfrom
johnwilkins:HCIDOCS-189
May 9, 2024
Merged

HCIDOCS-189: Add note with link to OCP docs about exposed CoreDNS port#75740
bscott-rh merged 1 commit intoopenshift:mainfrom
johnwilkins:HCIDOCS-189

Conversation

@johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented May 9, 2024

Moved an admonition from network requirements to overview and added a link to the DNS forwarding module.

Fixes: HCIDOCS-189

See https://issues.redhat.com/browse/HCIDOCS-189 for additional details.

Preview URL: http://184.23.213.161:8080/HCIDOCS-189/installing/installing_bare_metal_ipi/ipi-install-overview.html

For release(s): 4.14-4.16
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

…nk to DNS forwarding module.

Signed-off-by: John Wilkins <jowilkin@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024

@johnwilkins: This pull request references HCIDOCS-189 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Moved an admonition from network requirements to overview and added a link to the DNS forwarding module.

Fixes: HCIDOCS-189

See https://issues.redhat.com/browse/HCIDOCS-189 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-189/welcome/index.html

For release(s): 4.14-4.16
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2024
@johnwilkins
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024

@johnwilkins: This pull request references HCIDOCS-189 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Moved an admonition from network requirements to overview and added a link to the DNS forwarding module.

Fixes: HCIDOCS-189

See https://issues.redhat.com/browse/HCIDOCS-189 for additional details.

Preview URL: http://184.23.213.161:8080/HCIDOCS-189/installing/installing_bare_metal_ipi/ipi-install-overview.html

For release(s): 4.14-4.16
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2024

@johnwilkins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024

@johnwilkins: This pull request references HCIDOCS-189 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Moved an admonition from network requirements to overview and added a link to the DNS forwarding module.

Fixes: HCIDOCS-189

See https://issues.redhat.com/browse/HCIDOCS-189 for additional details.

Preview URL: http://184.23.213.161:8080/HCIDOCS-189/installing/installing_bare_metal_ipi/ipi-install-overview.html

For release(s): 4.14-4.16
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 9, 2024
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 9, 2024
@johnwilkins
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 9, 2024
@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 9, 2024
@bscott-rh bscott-rh added this to the Continuous Release milestone May 9, 2024
@bscott-rh
Copy link
Contributor

Merge review LGTM.

@bscott-rh bscott-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 9, 2024
@bscott-rh bscott-rh merged commit 8ab7ce3 into openshift:main May 9, 2024
@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #75748

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #75749

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #75750

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@apinnick
Copy link
Contributor

@johnwilkins This bug was reported for 4.10, so the fix should be cherrypicked to 4.12 and 4.13 as well.

@apinnick
Copy link
Contributor

/cherrypick enterprise-4.13

@apinnick
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@apinnick: new pull request created: #75823

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@apinnick: #75740 failed to apply on top of branch "enterprise-4.12":

Applying: Moved an admonition from network requirements to overview. Added a link to DNS forwarding module.
Using index info to reconstruct a base tree...
M	modules/ipi-install-network-requirements.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ipi-install-network-requirements.adoc
CONFLICT (content): Merge conflict in modules/ipi-install-network-requirements.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Moved an admonition from network requirements to overview. Added a link to DNS forwarding module.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@apinnick
Copy link
Contributor

@johnwilkins Please create a manual CP PR for enterprise-4.12.

johnwilkins added a commit to johnwilkins/openshift-docs that referenced this pull request May 13, 2024
Signed-off-by: John Wilkins <jowilkin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants