Skip to content

OBSDOCS-923: Add a note for the example OpenTelemetry Collector#79138

Merged
skopacz1 merged 1 commit intoopenshift:mainfrom
max-cx:OBSDOCS-923
Aug 27, 2024
Merged

OBSDOCS-923: Add a note for the example OpenTelemetry Collector#79138
skopacz1 merged 1 commit intoopenshift:mainfrom
max-cx:OBSDOCS-923

Conversation

@max-cx
Copy link
Contributor

@max-cx max-cx commented Jul 19, 2024

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16, 4.17

Issue:

https://issues.redhat.com/browse/OBSDOCS-923

Link to docs preview:

https://79138--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-installing.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

@max-cx: This pull request references OBSDOCS-923 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 19, 2024

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 22, 2024

@max-cx: This pull request references OBSDOCS-923 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16, 4.17

Issue:

https://issues.redhat.com/browse/OBSDOCS-923

Link to docs preview:

https://79138--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-installing.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx
Copy link
Contributor Author

max-cx commented Jul 23, 2024

@IshwarKanse, is this acceptable?
image
I'm asking because you mentioned the following in the Jira issue:
"This example OpenTelemetry Collector Custom Resource (CR) deploys an instance named 'otel' in a specified project, which receives trace data via OTLP, Jaeger, and Zipkin protocols, processes it with memory limiting and batching, and exports it using the debug exporter which exports data to console. For more configuration options, refer the Configuration of OpenTelemetry collector page."
However, if possible, I'd like to avoid repeating what the reader can read in the YAML block.

@IshwarKanse
Copy link
Member

@max-cx Looks good to me, we can tell the reader to refer the relevant sections.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2024

@max-cx: This pull request references OBSDOCS-923 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16, 4.17

Issue:

https://issues.redhat.com/browse/OBSDOCS-923

Link to docs preview:

https://79138--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-installing.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx
Copy link
Contributor Author

max-cx commented Jul 23, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 23, 2024
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 23, 2024
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm. Just one question.

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 23, 2024
@max-cx
Copy link
Contributor Author

max-cx commented Aug 26, 2024

/label merge-review-needed

Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM

@max-cx
Copy link
Contributor Author

max-cx commented Aug 27, 2024

/test deploy-preview

@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2024

@max-cx: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test validate-asciidoc
  • /test validate-portal

Use /test all to run all jobs.

Details

In response to this:

/test deploy-preview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@max-cx
Copy link
Contributor Author

max-cx commented Aug 27, 2024

/ok-to-test

@max-cx
Copy link
Contributor Author

max-cx commented Aug 27, 2024

/test all

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 27, 2024
@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2024

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skopacz1
Copy link
Contributor

/retest

@skopacz1 skopacz1 merged commit 4f6516c into openshift:main Aug 27, 2024
@skopacz1
Copy link
Contributor

/cherrypick enterprise-4.12

@skopacz1
Copy link
Contributor

/cherrypick enterprise-4.13

@skopacz1
Copy link
Contributor

/cherrypick enterprise-4.14

@skopacz1
Copy link
Contributor

/cherrypick enterprise-4.15

@skopacz1
Copy link
Contributor

/cherrypick enterprise-4.16

@skopacz1
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@skopacz1: new pull request created: #80945

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #80946

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #80947

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #80949

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #80950

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #80951

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants