Skip to content

OCPBUGS-37699: Remove mode=6 balance-alb from networking docs#79684

Merged
sheriff-rh merged 1 commit intoopenshift:mainfrom
dfitzmau:OCPBUGS-37699
Aug 5, 2024
Merged

OCPBUGS-37699: Remove mode=6 balance-alb from networking docs#79684
sheriff-rh merged 1 commit intoopenshift:mainfrom
dfitzmau:OCPBUGS-37699

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jul 30, 2024

Version(s):
4.12+

Issue:
OCPBUGS-37699

Link to docs preview:
Example: Bond interface node network configuration policy

  • SME has approved this change.
  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 30, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-37699, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-37699

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 30, 2024

@@ -15,8 +15,6 @@ to the cluster.
* mode=1 active-backup +
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Article https://access.redhat.com/solutions/67546 mentions that mode 1 is partially working..do I need to call out what might happen on using this mode?

@qiowang721
Copy link

Hi @dfitzmau could you also help to update the bond mode in this example? It uses balance-rr, which is also not in the supported list: https://docs.openshift.com/container-platform/4.15/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html#virt-example-nmstate-multiple-interfaces_k8s_nmstate-updating-node-network-config

@abhatt-rh abhatt-rh removed their request for review July 30, 2024 11:21
@cybertron
Copy link
Member

/lgtm

It might be helpful to also mention supported bond modes in the day 1 docs: https://docs.openshift.com/container-platform/4.16/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#configuring-host-dual-network-interfaces-in-the-install-config-yaml-file_ipi-install-installation-workflow

Right now it's more important to pick the right mode at install time than in an NNCP since the NNCP can't apply to the primary interface anyway.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 31, 2024
@qiowang721
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 31, 2024
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; merging.

@sheriff-rh sheriff-rh merged commit 896fa10 into openshift:main Aug 5, 2024
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-37699 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-37699

Link to docs preview:
Example: Bond interface node network configuration policy

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.17

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.16

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #79973

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #79974

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #79975

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #79977

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #79978

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sheriff-rh: #79684 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS-37699: Remove mode=6 balance-alb from networking docs
Using index info to reconstruct a base tree...
A	modules/ipi-install-configuring-host-dual-network-interfaces-in-the-install-config.yaml-file.adoc
M	modules/virt-example-nmstate-multiple-interfaces.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-example-nmstate-multiple-interfaces.adoc
CONFLICT (modify/delete): modules/ipi-install-configuring-host-dual-network-interfaces-in-the-install-config.yaml-file.adoc deleted in HEAD and modified in OCPBUGS-37699: Remove mode=6 balance-alb from networking docs. Version OCPBUGS-37699: Remove mode=6 balance-alb from networking docs of modules/ipi-install-configuring-host-dual-network-interfaces-in-the-install-config.yaml-file.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-37699: Remove mode=6 balance-alb from networking docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sheriff-rh
Copy link
Contributor

Looks like a manual cherrypick for 4.12 @dfitzmau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants