Use userdata task to persistent instance metadata routes in AWS by mburke5678 · Pull Request #80320 · openshift/openshift-docs

mburke5678 · 2024-08-09T18:18:34Z

openshift/windows-machine-config-operator#2296
https://issues.redhat.com/browse/WINC-1149

Previews:
Creating a Windows machine set on AWS -> Prereqs -> Third bullet
Sample YAML for a Windows MachineSet object on AWS -> Note after call-out 5
WMCO 10.17.0 supported platforms and Windows Server versions -> Footnote 1

QE review:

QE has approved this change.

ocpdocs-previewbot · 2024-08-09T18:32:57Z

🤖 Mon Oct 21 13:39:52 - Prow CI generated the docs preview:

https://80320--ocpdocs-pr.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-aws.html
https://80320--ocpdocs-pr.netlify.app/openshift-enterprise/latest/windows_containers/wmco_rn/windows-containers-release-notes-10-17-x-prereqs.html

jrvaldes

@mburke5678 thanks for working on this, PTAL at my suggestion.

jrvaldes · 2024-08-09T18:43:46Z

modules/windows-machineset-aws.adoc

+====
+For disconnected clusters, the Windows AMI must have the EC2LaunchV2 agent version 2.0.1643 or later installed.
+
+For more information on the EC2LaunchV2 agent, see link:https://aws.amazon.com/blogs/modernizing-with-aws/upgrade-ec2launch-v2[Which AMIs have EC2Launch v2?] in the AWS documentation.


I'd rather cite the official docs [1] than a blog post.

[1] https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2launch-v2-install.html

mburke5678 · 2024-08-14T15:18:03Z

@arnaik-rh CAn you please assign an appropriate QE resource to review this PR? Thank you in advance.

mburke5678 · 2024-09-05T19:05:50Z

@arnaik-rh Can you please assign an appropriate QE resource to review this PR? Thank you in advance.

ocpdocs-vale-bot · 2024-09-25T18:42:40Z

windows_containers/wmco_rn/windows-containers-release-notes-10-17-x-prereqs.adoc


 |Amazon Web Services (AWS)
-|Windows Server 2019, version 1809
+a|* Windows Server 2022, OS Build link:https://support.microsoft.com/en-us/topic/april-25-2022-kb5012637-os-build-20348-681-preview-2233d69c-d4a5-4be9-8c24-04a450861a8d[20348.681] or later ^[1]^


🤖 [error] RedHat.CaseSensitiveTerms: Use 'operating system' rather than 'OS'. For more information, see RedHat.CaseSensitiveTerms.

@mburke5678 I can see why you didn't use the vale bot's advice, it would clutter up the table and that's what the vendors call the build.

kalexand-rh · 2024-09-30T17:49:32Z

The branch/enterprise-4.18 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.17. And any PR going into main must also target the latest version branch (enterprise-4.18).

If the update in your PR does NOT apply to version 4.18 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

weinliu · 2024-10-17T07:20:25Z

/lgtm

openshift-ci · 2024-10-21T13:26:08Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2024-10-21T13:41:25Z

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

GroceryBoyJr · 2024-10-21T16:55:57Z

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

GroceryBoyJr

LGTM

GroceryBoyJr · 2024-10-21T17:02:22Z

windows_containers/wmco_rn/windows-containers-release-notes-10-17-x-prereqs.adoc


 |Amazon Web Services (AWS)
-|Windows Server 2019, version 1809
+a|* Windows Server 2022, OS Build link:https://support.microsoft.com/en-us/topic/april-25-2022-kb5012637-os-build-20348-681-preview-2233d69c-d4a5-4be9-8c24-04a450861a8d[20348.681] or later ^[1]^


@mburke5678 I can see why you didn't use the vale bot's advice, it would clutter up the table and that's what the vendors call the build.

GroceryBoyJr · 2024-10-21T17:03:15Z

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

openshift-ci · 2024-10-21T17:03:20Z

@GroceryBoyJr: Those labels are not set on the issue: peer-review-in-progress

Details

In response to this:

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mburke5678 · 2024-10-21T17:21:45Z

@GroceryBoyJr Thanks for the review. I should have mentioned about the OS. I did, indeed, leave it as is based on what Windows calls it. Nice catch

mburke5678 · 2024-10-21T17:23:00Z

/cherrypick enterprise-4.18

mburke5678 · 2024-10-21T17:23:04Z

/cherrypick enterprise-4.17

mburke5678 · 2024-10-21T17:23:10Z

/cherrypick enterprise-4.16

mburke5678 added branch/enterprise-4.16 branch/enterprise-4.17 labels Aug 9, 2024

mburke5678 added this to the Continuous Release milestone Aug 9, 2024

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2024

jrvaldes approved these changes Aug 9, 2024

View reviewed changes

openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2024

mburke5678 mentioned this pull request Aug 9, 2024

RN: Use userdata task to persistent instance metadata routes in AWS #80325

Closed

mburke5678 removed the branch/enterprise-4.16 label Sep 25, 2024

mburke5678 force-pushed the wmco-disconnected-EC2Launch branch from 5d1f027 to 85f97c6 Compare September 25, 2024 18:36

openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2024

ocpdocs-vale-bot reviewed Sep 25, 2024

View reviewed changes

kalexand-rh added the branch/enterprise-4.18 label Sep 30, 2024

openshift-ci bot assigned weinliu Oct 17, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024

Use userdata task to persistent instance metadata routes in AWS

a1f548d

mburke5678 force-pushed the wmco-disconnected-EC2Launch branch from 85f97c6 to a1f548d Compare October 21, 2024 13:26

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024

mburke5678 added branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 labels Oct 21, 2024

mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 21, 2024

GroceryBoyJr reviewed Oct 21, 2024

View reviewed changes

openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 21, 2024

mburke5678 merged commit 2cac280 into openshift:main Oct 21, 2024

mburke5678 deleted the wmco-disconnected-EC2Launch branch October 21, 2024 17:21

openshift deleted a comment from openshift-cherrypick-robot Oct 21, 2024

Conversation

mburke5678 commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrvaldes left a comment

Choose a reason for hiding this comment

Uh oh!

jrvaldes Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mburke5678 commented Aug 14, 2024

Uh oh!

mburke5678 commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-vale-bot Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

GroceryBoyJr Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

kalexand-rh commented Sep 30, 2024

Uh oh!

weinliu commented Oct 17, 2024

Uh oh!

openshift-ci bot commented Oct 21, 2024

Uh oh!

openshift-ci bot commented Oct 21, 2024

Uh oh!

GroceryBoyJr commented Oct 21, 2024

Uh oh!

GroceryBoyJr left a comment

Choose a reason for hiding this comment

Uh oh!

GroceryBoyJr Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

GroceryBoyJr commented Oct 21, 2024

Uh oh!

openshift-ci bot commented Oct 21, 2024

Uh oh!

mburke5678 commented Oct 21, 2024

Uh oh!

mburke5678 commented Oct 21, 2024

Uh oh!

mburke5678 commented Oct 21, 2024

Uh oh!

mburke5678 commented Oct 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mburke5678 commented Aug 9, 2024 •

edited

Loading

ocpdocs-previewbot commented Aug 9, 2024 •

edited

Loading

jrvaldes Aug 9, 2024 •

edited

Loading

mburke5678 commented Sep 5, 2024 •

edited

Loading