#CNV-38162: new inferfromvolume content#80363
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@sabrinajess: This pull request references CNV-38162 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sabrinajess
changed the title
|
@sabrinajess: This pull request references CNV-38162 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
🤖 Thu Sep 26 20:21:17 - Prow CI generated the docs preview: |
|
@sabrinajess: This pull request references CNV-38162 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sabrinajess
force-pushed
the
CNV31862
branch
2 times, most recently
from
0a6eff5 to
ce1e194
Compare
sabrinajess
force-pushed
the
CNV31862
branch
3 times, most recently
from
8a7fe8f to
aba8496
Compare
sabrinajess
force-pushed
the
CNV31862
branch
2 times, most recently
from
6c2e0b0 to
66eeea9
Compare
sabrinajess
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
sabrinajess
force-pushed
the
CNV31862
branch
from
66eeea9 to
762a64c
Compare
abhatt-rh
added
branch/enterprise-4.16
branch/enterprise-4.17
and removed
peer-review-in-progress
abhatt-rh
left a comment
abhatt-rh
left a comment
There was a problem hiding this comment.
Hi @sabrinajess,
Mostly LGTM! I have added a couple of comments related to style guidance and recommendation for rewording a few sentences for your consideration. Thank you!
|
/remove-label peer-review-in-progress |
openshift-ci
bot
added
peer-review-done
|
@abhatt-rh: Those labels are not set on the issue: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sabrinajess
force-pushed
the
CNV31862
branch
from
762a64c to
88fe5a1
Compare
|
New changes are detected. LGTM label has been removed. |
sabrinajess
force-pushed
the
CNV31862
branch
from
88fe5a1 to
32d05b7
Compare
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
jeana-redhat
added
the
merge-review-in-progress
jeana-redhat
left a comment
jeana-redhat
left a comment
There was a problem hiding this comment.
One format nit that should be addressed. Also suggest removing the use of "both" in a couple places while you're in here.
Otherwise, looking stellar 😎
/remove-label merge-review-in-progress
/remove-label merge-review-needed
| [id="virt-using-flags-specify_{context}"] | ||
| = Using flags to specify instance types and preferences | ||
|
|
||
| Specify both instance types and preferences by using flags. |
There was a problem hiding this comment.
| Specify both instance types and preferences by using flags. | |
| Specify instance types and preferences by using flags. |
openshift-ci
bot
removed
merge-review-in-progress
sabrinajess
force-pushed
the
CNV31862
branch
from
32d05b7 to
c2a0310
Compare
sabrinajess
force-pushed
the
CNV31862
branch
from
c2a0310 to
87ba920
Compare
|
@sabrinajess: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.16 |
|
@jeana-redhat: new pull request created: #82609 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jeana-redhat: new pull request created: #82610 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9 participants
Version(s): 4.16+
Issue: CNV-31862
Link to docs preview: https://80363--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-specifying-instance-preference.html
QE review:
Additional information: