OCPBUGS#31071: Changing catalog source name in disconnected workflow #80859
OCPBUGS#31071: Changing catalog source name in disconnected workflow #80859ShaunaDiaz merged 1 commit intoopenshift:mainfrom
Conversation
|
@rohennes: This pull request references Jira Issue OCPBUGS-31071, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
259900d to
4dd8a1d
Compare
|
/lgtm |
|
@josclark42: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label peer-review-needed |
| # ... | ||
| spec: | ||
| source: redhat-operators-v2 <1> | ||
| source: disconnected-redhat-operators-v2 <1> |
There was a problem hiding this comment.
Can this be redhat-operators-disconnected so that it matches the reference:
https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/gitops-subscriptions/argocd/example/policygentemplates/common-ranGen.yaml#L87
Thank you!
There was a problem hiding this comment.
Thanks @imiller0 - I've updated the instances accordingly
There was a problem hiding this comment.
@imiller0 - Any other issues or can I get this update merged? Thanks
…nd cannot be the same name as default catalog
4dd8a1d to
519c545
Compare
|
@rohennes: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@rohennes: This pull request references Jira Issue OCPBUGS-31071, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label merge-review-needed |
|
@rohennes Please get QE ack on the PR itself prior to merge. I see the task checked, but no QE ack on this one. |
Hi Shauna, josclark42 is the QE and has given this LGTM above on this PR. (Joshua Clark) |
|
Just a reminder about this one @ShaunaDiaz in case it slipped through the cracks, thanks! |
|
@rohennes: Jira Issue OCPBUGS-31071 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick enterprise-4.12 |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.17 |
The usual flow would be to put the merge-review-needed label back on in case the original reviewer is out after you got QE, etc. |
|
@ShaunaDiaz: #80859 failed to apply on top of branch "enterprise-4.12": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: #80859 failed to apply on top of branch "enterprise-4.13": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: #80859 failed to apply on top of branch "enterprise-4.14": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: #80859 failed to apply on top of branch "enterprise-4.15": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #81717 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #81718 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rohennes You can make the PCs and Slack me for merge, or put in the queue. |
OCPBUGS-31071: Changing catalog source name in disconnected workflow as its a custom catalog and cannot be the same name as default catalog
Version(s):
4.12+
Issue:
https://issues.redhat.com/browse/OCPBUGS-31071
Link to docs preview:
QE review:
Additional information: