Skip to content

OCPBUGS#31071: Changing catalog source name in disconnected workflow #80859

Merged
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
rohennes:OCPBUGS-31071
Sep 12, 2024
Merged

OCPBUGS#31071: Changing catalog source name in disconnected workflow #80859
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
rohennes:OCPBUGS-31071

Conversation

@rohennes
Copy link
Contributor

@rohennes rohennes commented Aug 26, 2024

OCPBUGS-31071: Changing catalog source name in disconnected workflow as its a custom catalog and cannot be the same name as default catalog

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-31071

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2024
@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-31071, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-31071: Changing catalog source name in disconnected workflow as its a custom catalog and cannot be the same name as default catalog

Version(s):
4.12+

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 26, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2024
@josclark42
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2024

@josclark42: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rohennes
Copy link
Contributor Author

/label peer-review-needed

Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! LGTM

@jldohmann jldohmann added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 30, 2024
# ...
spec:
source: redhat-operators-v2 <1>
source: disconnected-redhat-operators-v2 <1>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imiller0 - I've updated the instances accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imiller0 - Any other issues or can I get this update merged? Thanks

…nd cannot be the same name as default catalog
@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2024

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-31071, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

OCPBUGS-31071: Changing catalog source name in disconnected workflow as its a custom catalog and cannot be the same name as default catalog

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-31071

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 10, 2024
@ShaunaDiaz
Copy link
Contributor

@rohennes Please get QE ack on the PR itself prior to merge. I see the task checked, but no QE ack on this one.

@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 10, 2024
@rohennes
Copy link
Contributor Author

@rohennes Please get QE ack on the PR itself prior to merge. I see the task checked, but no QE ack on this one.

Hi Shauna, josclark42 is the QE and has given this LGTM above on this PR. (Joshua Clark)

@rohennes
Copy link
Contributor Author

Just a reminder about this one @ShaunaDiaz in case it slipped through the cracks, thanks!

@ShaunaDiaz ShaunaDiaz merged commit 69e5d66 into openshift:main Sep 12, 2024
@openshift-ci-robot
Copy link

@rohennes: Jira Issue OCPBUGS-31071 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

OCPBUGS-31071: Changing catalog source name in disconnected workflow as its a custom catalog and cannot be the same name as default catalog

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-31071

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.12

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.13

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.14

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.15

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.16

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.17

@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented Sep 12, 2024

Just a reminder about this one @ShaunaDiaz in case it slipped through the cracks, thanks!

The usual flow would be to put the merge-review-needed label back on in case the original reviewer is out after you got QE, etc.

@ShaunaDiaz ShaunaDiaz changed the title OCPBUGS-31071: Changing catalog source name in disconnected workflow OCPBUGS#31071: Changing catalog source name in disconnected workflow Sep 12, 2024
@openshift-cherrypick-robot

@ShaunaDiaz: #80859 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog
Using index info to reconstruct a base tree...
M	modules/cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
M	modules/cnf-topology-aware-lifecycle-manager-operator-update.adoc
A	snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
A	snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc
A	snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
A	snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc left in tree.
CONFLICT (modify/delete): snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc left in tree.
CONFLICT (modify/delete): snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc left in tree.
CONFLICT (modify/delete): snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc left in tree.
Auto-merging modules/cnf-topology-aware-lifecycle-manager-operator-update.adoc
Auto-merging modules/cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: #80859 failed to apply on top of branch "enterprise-4.13":

Applying: OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog
Using index info to reconstruct a base tree...
M	modules/cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
M	modules/cnf-topology-aware-lifecycle-manager-operator-update.adoc
A	snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
A	snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc
A	snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
A	snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc left in tree.
CONFLICT (modify/delete): snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc left in tree.
CONFLICT (modify/delete): snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc left in tree.
CONFLICT (modify/delete): snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc left in tree.
Auto-merging modules/cnf-topology-aware-lifecycle-manager-operator-update.adoc
Auto-merging modules/cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: #80859 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog
Using index info to reconstruct a base tree...
M	modules/cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
M	modules/cnf-topology-aware-lifecycle-manager-operator-update.adoc
A	snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
A	snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc
A	snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
A	snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc left in tree.
CONFLICT (modify/delete): snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc left in tree.
CONFLICT (modify/delete): snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc left in tree.
CONFLICT (modify/delete): snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc left in tree.
Auto-merging modules/cnf-topology-aware-lifecycle-manager-operator-update.adoc
Auto-merging modules/cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: #80859 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog
Using index info to reconstruct a base tree...
M	modules/cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
M	modules/cnf-topology-aware-lifecycle-manager-operator-update.adoc
A	snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
A	snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc
A	snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
A	snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-update.adoc left in tree.
CONFLICT (modify/delete): snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pgt-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc left in tree.
CONFLICT (modify/delete): snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pg-cnf-topology-aware-lifecycle-manager-operator-update.adoc left in tree.
CONFLICT (modify/delete): snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc deleted in HEAD and modified in OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog. Version OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog of snippets/pg-cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc left in tree.
Auto-merging modules/cnf-topology-aware-lifecycle-manager-operator-update.adoc
Auto-merging modules/cnf-topology-aware-lifecycle-manager-operator-troubleshooting.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-31071: Changing catalog source name as its a custom catalog and cannot be the same name as default catalog
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #81717

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #81718

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz
Copy link
Contributor

@rohennes You can make the PCs and Slack me for merge, or put in the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants