HCIDOCS-470: Update IPI installer docs by johnwilkins · Pull Request #81595 · openshift/openshift-docs

johnwilkins · 2024-09-11T00:45:24Z

Added Cisco firmware requirements.

Fixes: OCPBUGS-36900

See https://issues.redhat.com/browse/HCIDOCS-470 for additional details.

Preview URL: https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#bmc-addressing-for-cisco-cimc_ipi-install-installation-workflow
https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites.html#ipi-install-firmware-requirements-for-installing-with-virtual-media_ipi-install-prerequisites

For release(s): 4.15-4.17
QE Review:

QE has approved this change.

Signed-off-by: jowilkin@redhat.com

openshift-ci-robot · 2024-09-11T00:45:26Z

@johnwilkins: An error was encountered searching for bug OCPBUGS-36900 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Added Cisco firmware requirements.

Fixes: OCPBUGS-36900

See https://issues.redhat.com/browse/OCPBUGS-36900 for additional details.

Preview URL: http://jowilkin.com:8080/OCPBUGS-36900/welcome/index.html

For release(s): 4.15-4.17
QE Review:

QE has approved this change.

Signed-off-by: jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2024-09-11T00:51:14Z

🤖 Tue Sep 24 18:25:17 - Prow CI generated the docs preview:

https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html
https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites.html

johnwilkins · 2024-09-11T01:17:07Z

@racedo Can I get a QE review on this?

openshift-ci-robot · 2024-09-11T01:18:09Z

@johnwilkins: An error was encountered searching for bug OCPBUGS-36900 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Added Cisco firmware requirements.

Fixes: OCPBUGS-36900

See https://issues.redhat.com/browse/OCPBUGS-36900 for additional details.

Preview URL: https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html
https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites.html

For release(s): 4.15-4.17
QE Review:

QE has approved this change.

Signed-off-by: jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-09-11T01:19:16Z

@johnwilkins: An error was encountered searching for bug OCPBUGS-36900 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Added Cisco firmware requirements.

Fixes: OCPBUGS-36900

See https://issues.redhat.com/browse/OCPBUGS-36900 for additional details.

Preview URL: https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#bmc-addressing-for-cisco-cimc_ipi-install-installation-workflow
https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites.html#ipi-install-firmware-requirements-for-installing-with-virtual-media_ipi-install-prerequisites

For release(s): 4.15-4.17
QE Review:

QE has approved this change.

Signed-off-by: jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-09-15T17:36:29Z

@johnwilkins: An error was encountered searching for bug OCPBUGS-36900 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Added Cisco firmware requirements.

Fixes: OCPBUGS-36900

See https://issues.redhat.com/browse/OCPBUGS-36900 for additional details.

Preview URL: https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#bmc-addressing-for-cisco-cimc_ipi-install-installation-workflow
https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites.html#ipi-install-firmware-requirements-for-installing-with-virtual-media_ipi-install-prerequisites

For release(s): 4.15-4.17
QE Review:

QE has approved this change.

Signed-off-by: jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-09-15T17:37:49Z

@johnwilkins: An error was encountered searching for bug OCPBUGS-36900 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Added Cisco firmware requirements.

Fixes: OCPBUGS-36900

See https://issues.redhat.com/browse/HCIDOCS-470 for additional details.

Preview URL: https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#bmc-addressing-for-cisco-cimc_ipi-install-installation-workflow
https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites.html#ipi-install-firmware-requirements-for-installing-with-virtual-media_ipi-install-prerequisites

For release(s): 4.15-4.17
QE Review:

QE has approved this change.

Signed-off-by: jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-09-15T17:38:48Z

@johnwilkins: An error was encountered searching for bug HCIDOCS-470 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Added Cisco firmware requirements.

Fixes: OCPBUGS-36900

See https://issues.redhat.com/browse/HCIDOCS-470 for additional details.

Preview URL: https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#bmc-addressing-for-cisco-cimc_ipi-install-installation-workflow
https://81595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites.html#ipi-install-firmware-requirements-for-installing-with-virtual-media_ipi-install-prerequisites

For release(s): 4.15-4.17
QE Review:

QE has approved this change.

Signed-off-by: jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

johnwilkins · 2024-09-23T11:58:24Z

/label peer-review-needed

xenolinux · 2024-09-23T12:23:16Z

/label peer-review-in-progress

xenolinux

LGTM

A tiny nit to replace ' with double quotes "

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

modules/ipi-install-bmc-addressing-for-cisco-cimc.adoc

johnwilkins · 2024-09-24T18:20:15Z

/label merge-review-needed

openshift-ci · 2024-09-24T18:26:48Z

@johnwilkins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

adellape

Couple nits, but not blocking merge.

adellape · 2024-09-24T19:19:02Z

modules/ipi-install-bmc-addressing-for-cisco-cimc.adoc

+|Redfish virtual media| `redfish-virtualmedia://<server_kvm_ip>/redfish/v1/Systems/<serial_number>`
+|====
+
+To enable Redfish virtual media for Cisco UCS UCSX-210C-M6 hardware, use `redfish-virtualmedia://` in the `address` setting. The following example demonstrates using Redfish virtual media within the `install-config.yaml` file.


Colon since it a "the following example" lead-in?

Suggested change

To enable Redfish virtual media for Cisco UCS UCSX-210C-M6 hardware, use `redfish-virtualmedia://` in the `address` setting. The following example demonstrates using Redfish virtual media within the `install-config.yaml` file.

To enable Redfish virtual media for Cisco UCS UCSX-210C-M6 hardware, use `redfish-virtualmedia://` in the `address` setting. The following example demonstrates using Redfish virtual media within the `install-config.yaml` file.

Maybe throughout the PR, too, for any sentence leading into the block/example it's describing?

adellape · 2024-09-24T19:22:14Z

modules/ipi-install-bmc-addressing-for-cisco-cimc.adoc

+  baremetal:
+    hosts:
+      - name: <hostname>
+        role: <master | worker>


While personally I, too, like the | usage, technically non-standard to guidelines and should probably be just something like:

Suggested change

role: <master | worker>

role: <type>

with a callout listing the valid values. I see there are a few other IPI-related instances in other modules, too, tho. Not blocking merge.

openshift-cherrypick-robot · 2024-09-24T19:24:38Z

@adellape: cannot checkout enterprpise-4.17: error checking out "enterprpise-4.17": exit status 1 error: pathspec 'enterprpise-4.17' did not match any file(s) known to git

Details

In response to this:

/cherrypick enterprpise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-09-24T19:24:42Z

@adellape: cannot checkout enterprpise-4.16: error checking out "enterprpise-4.16": exit status 1 error: pathspec 'enterprpise-4.16' did not match any file(s) known to git

Details

In response to this:

/cherrypick enterprpise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-09-24T19:24:46Z

@adellape: cannot checkout enterprpise-4.15: error checking out "enterprpise-4.15": exit status 1 error: pathspec 'enterprpise-4.15' did not match any file(s) known to git

Details

In response to this:

/cherrypick enterprpise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

adellape · 2024-09-24T19:27:27Z

Lol typos...

adellape · 2024-09-24T19:27:34Z

/cherrypick enterprise-4.17

adellape · 2024-09-24T19:27:37Z

/cherrypick enterprise-4.16

adellape · 2024-09-24T19:27:39Z

/cherrypick enterprise-4.15

openshift-cherrypick-robot · 2024-09-24T19:28:21Z

@adellape: new pull request created: #82410

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-09-24T19:28:24Z

@adellape: new pull request created: #82411

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-09-24T19:28:25Z

@adellape: #81595 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-36900: Added Cisco firmware requirements..
Using index info to reconstruct a base tree...
M	installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
Falling back to patching base and 3-way merge...
Auto-merging installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
CONFLICT (content): Merge conflict in installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-36900: Added Cisco firmware requirements..
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

adellape · 2024-09-24T20:13:39Z

@johnwilkins 4.15 auto-cherrypick failed / will need a manual pick PR.

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2024

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2024

johnwilkins force-pushed the OCPBUGS-36900 branch from 51282b3 to 9b52b8f Compare September 15, 2024 17:36

johnwilkins changed the title ~~OCPBUGS-36900: Update IPI installer docs~~ HCIDOCS-470: Update IPI installer docs Sep 15, 2024

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 23, 2024

openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 23, 2024

xenolinux added branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 23, 2024

xenolinux added this to the Continuous Release milestone Sep 23, 2024

xenolinux added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 23, 2024

xenolinux reviewed Sep 23, 2024

View reviewed changes

modules/ipi-install-bmc-addressing-for-cisco-cimc.adoc Outdated Show resolved Hide resolved

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 23, 2024

OCPBUGS-36900: Added Cisco firmware requirements..

d05d06d

johnwilkins force-pushed the OCPBUGS-36900 branch from 70c9c64 to d05d06d Compare September 24, 2024 18:19

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 24, 2024

adellape self-assigned this Sep 24, 2024

adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 24, 2024

adellape reviewed Sep 24, 2024

View reviewed changes

adellape merged commit 83b2894 into openshift:main Sep 24, 2024

openshift-cherrypick-robot mentioned this pull request Sep 24, 2024

[enterprise-4.17] HCIDOCS-470: Update IPI installer docs #82410

Merged

openshift-cherrypick-robot mentioned this pull request Sep 24, 2024

[enterprise-4.16] HCIDOCS-470: Update IPI installer docs #82411

Merged

adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 24, 2024

johnwilkins mentioned this pull request Sep 24, 2024

HCIDOCS-470: Cherry pick #82426

Merged

1 task

	To enable Redfish virtual media for Cisco UCS UCSX-210C-M6 hardware, use `redfish-virtualmedia://` in the `address` setting. The following example demonstrates using Redfish virtual media within the `install-config.yaml` file.
	To enable Redfish virtual media for Cisco UCS UCSX-210C-M6 hardware, use `redfish-virtualmedia://` in the `address` setting. The following example demonstrates using Redfish virtual media within the `install-config.yaml` file.

Conversation

johnwilkins commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 11, 2024

Uh oh!

ocpdocs-previewbot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnwilkins commented Sep 11, 2024

Uh oh!

openshift-ci-robot commented Sep 11, 2024

Uh oh!

openshift-ci-robot commented Sep 11, 2024

Uh oh!

openshift-ci-robot commented Sep 15, 2024

Uh oh!

openshift-ci-robot commented Sep 15, 2024

Uh oh!

openshift-ci-robot commented Sep 15, 2024

Uh oh!

johnwilkins commented Sep 23, 2024

Uh oh!

xenolinux commented Sep 23, 2024

Uh oh!

xenolinux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

johnwilkins commented Sep 24, 2024

Uh oh!

openshift-ci bot commented Sep 24, 2024

Uh oh!

adellape left a comment

Choose a reason for hiding this comment

Uh oh!

adellape Sep 24, 2024

Choose a reason for hiding this comment

Uh oh!

adellape Sep 24, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-cherrypick-robot commented Sep 24, 2024

Uh oh!

openshift-cherrypick-robot commented Sep 24, 2024

Uh oh!

openshift-cherrypick-robot commented Sep 24, 2024

Uh oh!

adellape commented Sep 24, 2024

Uh oh!

adellape commented Sep 24, 2024

Uh oh!

adellape commented Sep 24, 2024

Uh oh!

adellape commented Sep 24, 2024

Uh oh!

openshift-cherrypick-robot commented Sep 24, 2024

Uh oh!

openshift-cherrypick-robot commented Sep 24, 2024

Uh oh!

openshift-cherrypick-robot commented Sep 24, 2024

Uh oh!

adellape commented Sep 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

johnwilkins commented Sep 11, 2024 •

edited

Loading

ocpdocs-previewbot commented Sep 11, 2024 •

edited

Loading