Skip to content

OSDOCS 10197: Added the illustration of enclave support and explained the diagram.#81930

Merged
skopacz1 merged 1 commit intoopenshift:mainfrom
subhtk:osdocs10197
Sep 20, 2024
Merged

OSDOCS 10197: Added the illustration of enclave support and explained the diagram.#81930
skopacz1 merged 1 commit intoopenshift:mainfrom
subhtk:osdocs10197

Conversation

@subhtk
Copy link
Contributor

@subhtk subhtk commented Sep 17, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 17, 2024 •
edited
Loading

🤖 Fri Sep 20 15:40:09 - Prow CI generated the docs preview:

https://81930--ocpdocs-pr.netlify.app/

@subhtk subhtk force-pushed the osdocs10197 branch 4 times, most recently from 613c105 to 64a856b Compare September 17, 2024 11:29
lmzuccarelli
lmzuccarelli reviewed Sep 17, 2024
View reviewed changes
Copy link

@lmzuccarelli lmzuccarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subhtk - This is great thanks for the update

@sherine-k
Copy link

sherine-k commented Sep 17, 2024

LGTM for me
This is a great addition!
Thanks @subhtk + Jess Schaefer

@subhtk
Copy link
Contributor Author

subhtk commented Sep 18, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 18, 2024
@skopacz1 skopacz1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.16 branch/enterprise-4.17 labels Sep 18, 2024
@skopacz1 skopacz1 added this to the Continuous Release milestone Sep 18, 2024
skopacz1
skopacz1 reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, please let me know if you have any questions about my feedback. Thanks!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 18, 2024
@subhtk
Copy link
Contributor Author

subhtk commented Sep 20, 2024

/ label merge-review-needed

skopacz1
skopacz1 reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit and I think this PR is good to go!

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2024

@subhtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@subhtk
Copy link
Contributor Author

subhtk commented Sep 20, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 20, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 20, 2024
skopacz1
skopacz1 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM

@skopacz1 skopacz1 merged commit 655bb36 into openshift:main Sep 20, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented Sep 20, 2024

/cherrypick enterprise-4.16

@skopacz1
Copy link
Contributor

skopacz1 commented Sep 20, 2024

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 20, 2024

@skopacz1: new pull request created: #82229

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 20, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 20, 2024

@skopacz1: new pull request created: #82230

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 20, 2024
Merged
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skopacz1 skopacz1 skopacz1 approved these changes

+1 more reviewer

@lmzuccarelli lmzuccarelli lmzuccarelli left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.16 branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@subhtk @ocpdocs-previewbot @sherine-k @skopacz1 @openshift-cherrypick-robot @lmzuccarelli