Skip to content

TELCODOCS-1867 - remove configuration step#82163

Merged
michaelryanpeter merged 1 commit intoopenshift:mainfrom
slovern:TELCODOCS-1867-II
Sep 20, 2024
Merged

TELCODOCS-1867 - remove configuration step#82163
michaelryanpeter merged 1 commit intoopenshift:mainfrom
slovern:TELCODOCS-1867-II

Conversation

@slovern
Copy link
Contributor

@slovern slovern commented Sep 19, 2024

[TELCODOCS-1867](https://issues.redhat.com//browse/TELCODOCS-1867) - remove configuration step

Version(s): 4.17

Issue: https://issues.redhat.com//browse/TELCODOCS-1867

Link to docs preview: Configuring the integration of MetalLB and FRR-K8s

QE review:

  • QE has approved this change.

Additional information: This is the removal of the section Activating the integration of MetalLB and FRR-K8s as this is now the default backend and does not require activation.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 19, 2024

FRRouting (FRR) is a free, open source internet routing protocol suite for Linux and UNIX platforms.
`FRR-K8s` is a Kubernetes based DaemonSet that exposes a subset of the `FRR` API in a Kubernetes-compliant manner.
As a cluster administrator, you can use the `FRRConfiguration` custom resource (CR) to configure `MetalLB` to use `FRR-K8s` as the backend.
As a cluster administrator, you can use the `FRRConfiguration` custom resource (CR) to configure the way `MetalLB` uses `FRR-K8s`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is more "to leverage the FRR instance beyond the features offered by MetalLB"

Copy link
Contributor Author

@slovern slovern Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to: "As a cluster administrator, you can use the FRRConfiguration custom resource (CR) to avail of some of the FRR services not provided by MetalLB, for example, receiving routes."

@slovern slovern force-pushed the TELCODOCS-1867-II branch 2 times, most recently from 6990134 to 66ac8e1 Compare September 20, 2024 09:15
@fedepaol
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@slovern
Copy link
Contributor Author

slovern commented Sep 20, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 20, 2024
@slovern
Copy link
Contributor Author

slovern commented Sep 20, 2024

/label telco

@openshift-ci openshift-ci bot added the telco Label for all Telco PRs label Sep 20, 2024
@gkopels
Copy link

gkopels commented Sep 20, 2024

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2024

@gkopels: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 20, 2024
As a cluster administrator, you can use the `FRRConfiguration` custom resource (CR) to configure `MetalLB` to use `FRR-K8s` as the backend.
You can use this to avail of FRR services, for example, receiving routes.
If you run `MetalLB` with `FRR-K8s` as a backend, `MetalLB` generates the `FRR-K8s` configuration corresponding to the MetalLB configuration applied.
As a cluster administrator, you can use the `FRRConfiguration` custom resource (CR) to avail of some of the FRR services not provided by MetalLB, for example, receiving routes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure "avail" is the best word here. (I see that it was already there before you came along.)

Suggested change
As a cluster administrator, you can use the `FRRConfiguration` custom resource (CR) to avail of some of the FRR services not provided by MetalLB, for example, receiving routes.
As a cluster administrator, you can use the `FRRConfiguration` custom resource (CR) to take advantage of some of the FRR services not provided by MetalLB, for example, receiving routes.
Suggested change
As a cluster administrator, you can use the `FRRConfiguration` custom resource (CR) to avail of some of the FRR services not provided by MetalLB, for example, receiving routes.
As a cluster administrator, you can use the `FRRConfiguration` custom resource (CR) to access some of the FRR services not provided by MetalLB, for example, receiving routes.

@mburke5678
Copy link
Contributor

@slovern One suggestion. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.17 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 20, 2024
@mburke5678 mburke5678 added this to the Planned for 4.17 GA milestone Sep 20, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2024

New changes are detected. LGTM label has been removed.

@slovern
Copy link
Contributor Author

slovern commented Sep 20, 2024

thanks for the review @mburke5678
I've taken on your suggestion

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2024

@slovern: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@slovern
Copy link
Contributor Author

slovern commented Sep 20, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 20, 2024
@michaelryanpeter
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 20, 2024
@michaelryanpeter michaelryanpeter merged commit 11a6893 into openshift:main Sep 20, 2024
@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@michaelryanpeter: new pull request created: #82231

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@slovern
Copy link
Contributor Author

slovern commented Sep 20, 2024

thanks for the merge @michaelryanpeter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. telco Label for all Telco PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants