OCPBUGS#42398: Add the service account spec and to Upgrade edge docs#82515
Conversation
openshift-ci
bot
added
the
size/S
michaelryanpeter
force-pushed
the
ocpbugs-42398-add-service-account-spec-to-upgrade-edge-docs
branch
from
2277077 to
38f9a76
Compare
|
🤖 Wed Sep 25 22:58:40 - Prow CI generated the docs preview: https://82515--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/arch/operator-controller.html |
|
/retest-required |
|
@michaelryanpeter: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jianzhangbjz or @Xia-Zhao-rh PTAL |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
LGTM |
xenolinux
added
peer-review-in-progress
xenolinux
left a comment
xenolinux
left a comment
There was a problem hiding this comment.
One question; otherwise LGTM!
| serviceAccount: | ||
| name: <service_account> |
There was a problem hiding this comment.
Since this var is being added now, does it need a call out and description?
IMO, a call out can be added - but up to you.
There was a problem hiding this comment.
I am going to add an xref to the supporting documentation on service accounts once that content merges. I debated adding a call out here for the sake of completeness. When I tried it, it actually distracted from the point of the module, which is focused on upgrade edges.
There was a problem hiding this comment.
Anyhow, that is just to say that I think your suggestion is a good idea, but it didn't work for this content in the end. Thanks, @xenolinux!
xenolinux
added
peer-review-done
|
/cherrypick enterprise-4.17 |
|
@michaelryanpeter: new pull request created: #82635 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Version(s): 4.17
Issue: OCPBUGS-42398
Link to docs preview:
QE review:
Additional information: