Skip to content

OADP-3472 Added warning for windows vm backup fail#83327

Merged
abhatt-rh merged 1 commit intoopenshift:mainfrom
shdeshpa07:OADP-3472-Windows-Backup-Fails
Nov 5, 2024
Merged

OADP-3472 Added warning for windows vm backup fail#83327
abhatt-rh merged 1 commit intoopenshift:mainfrom
shdeshpa07:OADP-3472-Windows-Backup-Fails

Conversation

@shdeshpa07
Copy link
Contributor

@shdeshpa07 shdeshpa07 commented Oct 10, 2024 •
edited
Loading

Jira

Added warning in OADP virt doc section regarding windows vm backup fail

Version

  • OCP 4.13 → OCP 4.18

Preview

Look for the warning at the end of the virt dpa.

QE Review

  • QE has approved this change.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Oct 10, 2024 •
edited
Loading

/label OADP

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 10, 2024 •
edited
Loading

🤖 Tue Nov 05 11:07:18 - Prow CI generated the docs preview:

https://83327--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-kubevirt.html

anarnold97
anarnold97 reviewed Oct 15, 2024
View reviewed changes
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2024
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Oct 16, 2024 •
edited
Loading

@weshayutin @amastbau - I have added a warning for the issue. Could you please review this PR? Thanks.

@shdeshpa07 shdeshpa07 force-pushed the OADP-3472-Windows-Backup-Fails branch from 9011c66 to 4daea35 Compare October 16, 2024 05:01
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2024
amastbau
amastbau reviewed Oct 16, 2024
View reviewed changes
@weshayutin
Copy link

weshayutin commented Oct 21, 2024

@mrnold please have a look

@shdeshpa07 shdeshpa07 force-pushed the OADP-3472-Windows-Backup-Fails branch from 58e606d to 18472f2 Compare October 23, 2024 10:59
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Oct 23, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 23, 2024
@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 23, 2024
@skrthomas
Copy link
Contributor

skrthomas commented Oct 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2024
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Oct 24, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 24, 2024
@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 24, 2024
kcarmichael08
kcarmichael08 reviewed Oct 24, 2024
View reviewed changes
kcarmichael08
kcarmichael08 reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, do you mind please removing the extra comma? I will then merge. Thank you!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2024

New changes are detected. LGTM label has been removed.

@shdeshpa07 shdeshpa07 force-pushed the OADP-3472-Windows-Backup-Fails branch from e7eec04 to 3816d85 Compare October 25, 2024 06:02
@abhatt-rh abhatt-rh added this to the Continuous Release milestone Nov 5, 2024
abhatt-rh
abhatt-rh reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shdeshpa07, an absolute minor nit but since this is a snippet, the nit might show up in various other places. Can you please consider fixing it?

@shdeshpa07
added warning for windows vm backup fail
905ec1c 
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
@shdeshpa07 shdeshpa07 force-pushed the OADP-3472-Windows-Backup-Fails branch from 70b0011 to 905ec1c Compare November 5, 2024 10:51
@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2024

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Nov 5, 2024

Hi @shdeshpa07, an absolute minor nit but since this is a snippet, the nit might show up in various other places. Can you please consider fixing it?

Hi @abhatt-rh - Done. thanks.

@abhatt-rh abhatt-rh merged commit 260ce45 into openshift:main Nov 5, 2024
@abhatt-rh
Copy link
Contributor

abhatt-rh commented Nov 5, 2024

/cherrypick enterprise-4.18

@abhatt-rh
Copy link
Contributor

abhatt-rh commented Nov 5, 2024 •
edited
Loading

/cherrypick enterprise-4.17

@abhatt-rh
Copy link
Contributor

abhatt-rh commented Nov 5, 2024

/cherrypick enterprise-4.16

@abhatt-rh
Copy link
Contributor

abhatt-rh commented Nov 5, 2024

/cherrypick enterprise-4.15

@abhatt-rh
Copy link
Contributor

abhatt-rh commented Nov 5, 2024

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2024

@abhatt-rh: new pull request created: #84470

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2024
Merged
@abhatt-rh
Copy link
Contributor

abhatt-rh commented Nov 5, 2024

/cherrypick enterprise-4.13

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2024

@abhatt-rh: new pull request created: #84471

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Nov 5, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2024

@abhatt-rh: new pull request created: #84472

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2024

@abhatt-rh: new pull request created: #84473

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2024

@abhatt-rh: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.18 from head openshift-cherrypick-robot:cherry-pick-83327-to-enterprise-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-83327-to-enterprise-4.18."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2024

@abhatt-rh: new pull request created: #84474

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2024
Merged
@abhatt-rh
Copy link
Contributor

abhatt-rh commented Nov 5, 2024

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2024

@abhatt-rh: new pull request created: #84475

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2024
Merged
@abhatt-rh abhatt-rh removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 5, 2024
@shdeshpa07 shdeshpa07 deleted the OADP-3472-Windows-Backup-Fails branch July 25, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhatt-rh abhatt-rh abhatt-rh left review comments

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

+3 more reviewers

@amastbau amastbau amastbau left review comments

@anarnold97 anarnold97 anarnold97 left review comments

@mrnold mrnold mrnold approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skrthomas skrthomas

Labels

branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.