[OSDOCS-12142]: Adding backup/restore docs for HCP on OpenShift Virt#84179
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Tue Nov 05 14:17:41 - Prow CI generated the docs preview: |
lahinson
force-pushed
the
osdocs-12142-backup-restore-hcp-kubevirt
branch
from
aba4729 to
d9fc3ff
Compare
|
Thanks @lahinson ! /lgtm |
lahinson
added
peer-review-needed
jeana-redhat
added
the
peer-review-in-progress
jeana-redhat
left a comment
jeana-redhat
left a comment
There was a problem hiding this comment.
Really nice! Most of my comments are just things to consider.
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
| ---- | ||
| + | ||
| <1> This field starts the recovery of pods with the included persistent volumes. | ||
| <2> By setting `existingResourcePolicy` to `update` ensures that any objects are overwritten with backup content. This action can cause issues with objects that contain immutable fields, which is why you deleted the `HostedCluster`, node pools, and PVCs. If you do not set this policy, the Velero engine skips the restoration of objects that already exist. |
There was a problem hiding this comment.
| <2> By setting `existingResourcePolicy` to `update` ensures that any objects are overwritten with backup content. This action can cause issues with objects that contain immutable fields, which is why you deleted the `HostedCluster`, node pools, and PVCs. If you do not set this policy, the Velero engine skips the restoration of objects that already exist. | |
| <2> Setting `existingResourcePolicy` to `update` ensures that any existing objects are overwritten with backup content. This action can cause issues with objects that contain immutable fields, which is why you deleted the `HostedCluster`, node pools, and PVCs. If you do not set this policy, the Velero engine skips the restoration of objects that already exist. |
There was a problem hiding this comment.
Since the option of skipping this is mentioned, are there any consequences or considerations that should be covered? If you don't set the policy, did you need to delete the objects at the start?
There was a problem hiding this comment.
@nunnatsa Jeana has another good question here. Can you answer it?
openshift-ci
bot
added
peer-review-done
lahinson
force-pushed
the
osdocs-12142-backup-restore-hcp-kubevirt
branch
from
d9fc3ff to
c6bc0e2
Compare
|
New changes are detected. LGTM label has been removed. |
lahinson
force-pushed
the
osdocs-12142-backup-restore-hcp-kubevirt
branch
from
c6bc0e2 to
ed92fd1
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.17 |
|
@lahinson: new pull request created: #84535 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #84536 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Version(s): 4.17+
Issue: https://issues.redhat.com/browse/OSDOCS-12142
Link to docs preview: https://84179--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp_high_availability/hcp-backup-restore-virt.html
QE review:
Additional information: To be merged on Nov. 6 in alignment with the MCE 2.7 release.