Skip to content

OBSDOCS-1257#84182

Merged
skrthomas merged 1 commit intoopenshift:enterprise-4.16from
libander:OBSDOCS-1257
Nov 20, 2024
Merged

OBSDOCS-1257#84182
skrthomas merged 1 commit intoopenshift:enterprise-4.16from
libander:OBSDOCS-1257

Conversation

@libander
Copy link
Contributor

@libander libander commented Oct 28, 2024 •
edited
Loading

@libander
Copy link
Contributor Author

libander commented Oct 28, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 28, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 28, 2024 •
edited
Loading

🤖 Wed Oct 30 03:13:54 - Prow CI generated the docs preview:

https://84182--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/cluster-logging-deploying.html
https://84182--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/cluster-logging.html

skrthomas
skrthomas reviewed Oct 28, 2024
View reviewed changes
@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 28, 2024
@kabirbhartiRH
Copy link

kabirbhartiRH commented Oct 29, 2024

LGTM according to the notification we have on OCP console.

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2024

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

JoaoBraveCoding
JoaoBraveCoding reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing some context but if this PR is targetting OBSDOCS-1257 shouldn't we also remove the section Installing Logging with Elasticsearch using the CLI?

@libander
Copy link
Contributor Author

libander commented Oct 30, 2024

I might be missing some context but if this PR is targetting OBSDOCS-1257 shouldn't we also remove the section Installing Logging with Elasticsearch using the CLI?

That is outside of the scope of this PR, but yes. That does need to be done as well & is on my mind.

JoaoBraveCoding
JoaoBraveCoding approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
skrthomas
skrthomas reviewed Nov 4, 2024
View reviewed changes
@libander
Copy link
Contributor Author

libander commented Nov 16, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 16, 2024
@snarayan-redhat snarayan-redhat added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 18, 2024
@snarayan-redhat
Copy link
Contributor

snarayan-redhat commented Nov 18, 2024

@libander You might want to address the above peer review comment before I can merge this PR.

@libander
Copy link
Contributor Author

libander commented Nov 19, 2024 •
edited
Loading

@libander You might want to address the above peer review comment before I can merge this PR.

Oh my goodness, I had, but I didn't realize my comment doing so was still "pending". Thank you!

@libander libander requested a review from skrthomas November 20, 2024 09:04
@skrthomas skrthomas merged commit c54089f into openshift:enterprise-4.16 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skrthomas skrthomas Awaiting requested review from skrthomas

1 more reviewer

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoaoBraveCoding JoaoBraveCoding

Labels

lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@libander @ocpdocs-previewbot @kabirbhartiRH @snarayan-redhat @JoaoBraveCoding @skrthomas