Skip to content

OSDOCS-12604: inline containerfiles and update with dnf#84641

Merged
jldohmann merged 1 commit intoopenshift:mainfrom
jldohmann:OSDOCS-12604
Nov 11, 2024
Merged

OSDOCS-12604: inline containerfiles and update with dnf#84641
jldohmann merged 1 commit intoopenshift:mainfrom
jldohmann:OSDOCS-12604

Conversation

@jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Nov 7, 2024

@jldohmann jldohmann added this to the Continuous Release milestone Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

@jldohmann: This pull request references OSDOCS-12604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-12604

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

@jldohmann: This pull request references OSDOCS-12604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-12604

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

@jldohmann: This pull request references OSDOCS-12604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-12604

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: related to #81649

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

@jldohmann: This pull request references OSDOCS-12604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.17+

Issue: https://issues.redhat.com/browse/OSDOCS-12604

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: related to #81649

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann jldohmann changed the title OSDOCS-12604: inline containerfiles OSDOCS-12604: inline containerfiles and update with dnf Nov 7, 2024
@jldohmann
Copy link
Contributor Author

@jlebon @HuijingHei ive updated the coreos layering containerfiles to not be pulled from that older repo 🙂 and for them to use dnf could you PTAL? thank you!

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 7, 2024

🤖 Mon Nov 11 20:35:17 - Prow CI generated the docs preview:

https://84641--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/mco-coreos-layering.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

@jldohmann: This pull request references OSDOCS-12604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.17+

Issue: https://issues.redhat.com/browse/OSDOCS-12604

Link to docs preview: https://84641--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/mco-coreos-layering.html#coreos-layering-examples_mco-coreos-layering

QE review:

  • QE has approved this change.

Additional information: related to #81649

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann jldohmann added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 7, 2024
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024

@jldohmann: This pull request references OSDOCS-12604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.17+

Issue: https://issues.redhat.com/browse/OSDOCS-12604

Link to docs preview: https://84641--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/mco-coreos-layering.html#coreos-layering-examples_mco-coreos-layering

QE review:

  • QE has approved this change.

Additional information: related to #81649

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 8, 2024
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 8, 2024
@jldohmann
Copy link
Contributor Author

i just noticed attributes arent resolving in the code block, so subsequent pushes are to fix that

@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2024

@jldohmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jldohmann jldohmann merged commit 288d4c6 into openshift:main Nov 11, 2024
@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.18

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@jldohmann: new pull request created: #84770

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jldohmann: new pull request created: #84771

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jldohmann
Copy link
Contributor Author

will need another PR to inline these examples for 4.12 through 4.16 without dnf

@jldohmann jldohmann deleted the OSDOCS-12604 branch November 11, 2024 22:44
@jlebon
Copy link
Member

jlebon commented Nov 12, 2024

will need another PR to inline these examples for 4.12 through 4.16 without dnf

FWIW, I don't think this is strictly necessary. The repo itself isn't going away, and I think having it be read-only shouldn't break the openshift-docs sourcing from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants