Skip to content

TELCODOCS#2040: Multi-network policy support for bond CNI and IPVLAN#84671

Merged
stevsmit merged 1 commit intoopenshift:mainfrom
sr1kar99:2040-multus-multi-network-policy
Nov 19, 2024
Merged

TELCODOCS#2040: Multi-network policy support for bond CNI and IPVLAN#84671
stevsmit merged 1 commit intoopenshift:mainfrom
sr1kar99:2040-multus-multi-network-policy

Conversation

@sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Nov 8, 2024 •
edited
Loading

Version(s):
4.18

Issues:

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 8, 2024 •
edited
Loading

🤖 Tue Nov 12 10:31:53 - Prow CI generated the docs preview:

https://84671--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/configuring-multi-network-policy.html

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Nov 8, 2024

Hi @zeeke
Could you please review this PR?
Thanks!

zeeke
zeeke reviewed Nov 8, 2024
View reviewed changes
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Nov 11, 2024

Hi @ajaggapa
Could you please review this PR?
Thanks!

@sr1kar99 sr1kar99 force-pushed the 2040-multus-multi-network-policy branch from d32892a to 735b3a6 Compare November 11, 2024 07:14
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2024
@ajaggapa
Copy link

ajaggapa commented Nov 12, 2024

@sr1kar99

You must specify an annotation with the name of the network attachment definition that defines the macvlan or SR-IOV additional network

Please modify this line as mentioned below. Since, this api is not specific to only macvlan and sriov networks anymore.

You must specify an annotation with the name of the network attachment definition that defines the additional network

@sr1kar99 sr1kar99 force-pushed the 2040-multus-multi-network-policy branch from 735b3a6 to 297bb8c Compare November 12, 2024 10:10
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2024
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Nov 12, 2024

@sr1kar99

You must specify an annotation with the name of the network attachment definition that defines the macvlan or SR-IOV additional network

Please modify this line as mentioned below. Since, this api is not specific to only macvlan and sriov networks anymore.

You must specify an annotation with the name of the network attachment definition that defines the additional network

@ajaggapa Updated as per the suggestion.

@ajaggapa
Copy link

ajaggapa commented Nov 12, 2024

LGTM 👍

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Nov 12, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 12, 2024
@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lahinson lahinson added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 12, 2024
lahinson
lahinson reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.18 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 12, 2024
@lahinson lahinson added this to the Planned for 4.18 GA milestone Nov 12, 2024
@zeeke
Copy link

zeeke commented Nov 18, 2024

/lgtm

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Nov 18, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 18, 2024
@stevsmit stevsmit removed the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 19, 2024
@stevsmit stevsmit added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 19, 2024
@stevsmit
Copy link
Member

stevsmit commented Nov 19, 2024

lgtm

@stevsmit stevsmit removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 19, 2024
@stevsmit stevsmit merged commit 64b90c7 into openshift:main Nov 19, 2024
@stevsmit
Copy link
Member

stevsmit commented Nov 19, 2024

/cherry-pick enterprise-4.18

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 19, 2024

@stevsmit: new pull request created: #85129

Details

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahinson lahinson lahinson left review comments

+1 more reviewer

@zeeke zeeke zeeke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@zeeke zeeke

Labels

branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.18 GA

Development

Successfully merging this pull request may close these issues.

7 participants

@sr1kar99 @ocpdocs-previewbot @ajaggapa @zeeke @stevsmit @openshift-cherrypick-robot @lahinson