Skip to content

CNV-45177: Remove ambiguity from a release note#85112

Merged
bergerhoffer merged 1 commit intoopenshift:enterprise-4.16from
jhradilek:CNV-45177-ambiguous-description
Nov 21, 2024
Merged

CNV-45177: Remove ambiguity from a release note#85112
bergerhoffer merged 1 commit intoopenshift:enterprise-4.16from
jhradilek:CNV-45177-ambiguous-description

Conversation

@jhradilek
Copy link
Contributor

@jhradilek jhradilek commented Nov 19, 2024

Version(s): 4.16

Issue: CNV-45177

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
The original phrasing of the release note could have been misleading as it did not specify what is being hot-plugged where. This fix removes this ambiguity.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024

@jhradilek: This pull request references CNV-45177 which is a valid jira issue.

Details

In response to this:

Version(s): 4.16

Issue: CNV-45177

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
The original phrasing of the release note could have been misleading as it did not specify what is being hot-plugged where. This fix removes this ambiguity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhradilek
Copy link
Contributor Author

/label cnv

@openshift-ci openshift-ci bot added CNV Label for all CNV PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2024
@ocpdocs-previewbot
Copy link

🤖 Tue Nov 19 13:45:31 - Prow CI generated the docs preview:

https://85112--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-16-release-notes.html

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2024

@jhradilek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024

@jhradilek: This pull request references CNV-45177 which is a valid jira issue.

Details

In response to this:

Version(s): 4.16

Issue: CNV-45177

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
The original phrasing of the release note could have been misleading as it did not specify what is being hot-plugged where. This fix removes this ambiguity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhradilek
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 20, 2024
@aspauldi
Copy link

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 20, 2024
Copy link

@aspauldi aspauldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@jhradilek
Copy link
Contributor Author

Thank you, @aspauldi.

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 20, 2024
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 21, 2024
@bergerhoffer bergerhoffer added this to the Continuous Release milestone Nov 21, 2024
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge!

@bergerhoffer bergerhoffer merged commit f3a6939 into openshift:enterprise-4.16 Nov 21, 2024
@jhradilek jhradilek deleted the CNV-45177-ambiguous-description branch November 21, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants