Skip to content

OBSDOCS-1501 - Logging 5.9.9 RN - OCP 4.13 thru 4.16#85214

Merged
adellape merged 1 commit intoopenshift:enterprise-4.16from
libander:OBSDOCS-1501
Nov 21, 2024
Merged

OBSDOCS-1501 - Logging 5.9.9 RN - OCP 4.13 thru 4.16#85214
adellape merged 1 commit intoopenshift:enterprise-4.16from
libander:OBSDOCS-1501

Conversation

@libander
Copy link
Contributor

@libander libander commented Nov 20, 2024

@libander
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 20, 2024
@libander
Copy link
Contributor Author

@anpingli - Review please.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 20, 2024

@libander libander force-pushed the OBSDOCS-1501 branch 2 times, most recently from 24b04bc to fb274da Compare November 20, 2024 03:09
@anpingli
Copy link

LGTM

@aspauldi
Copy link

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 20, 2024
Copy link

@aspauldi aspauldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The only thing I noticed was in the preview, in which there is one NOTE followed without intervening content by another NOTE. I don't think that you updated this section, but I wanted to mention that the Red Hat Supplementary Style Guide advises to avoid placing multiple admonitions close together (https://redhat-documentation.github.io/supplementary-style-guide/#admonitions).

@aspauldi
Copy link

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 20, 2024
@libander
Copy link
Contributor Author

Hi! The only thing I noticed was in the preview, in which there is one NOTE followed without intervening content by another NOTE. I don't think that you updated this section, but I wanted to mention that the Red Hat Supplementary Style Guide advises to avoid placing multiple admonitions close together (https://redhat-documentation.github.io/supplementary-style-guide/#admonitions).

Solid feedback, thank you so much! Fixed. :)

@libander
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 20, 2024
@adellape
Copy link
Contributor

/retest-required

@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 21, 2024
@adellape adellape self-assigned this Nov 21, 2024
@adellape
Copy link
Contributor

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2024

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adellape adellape merged commit f12188a into openshift:enterprise-4.16 Nov 21, 2024
@adellape
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@adellape: new pull request created: #85260

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adellape
Copy link
Contributor

/cherrypick enterprise-4.14

@adellape
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@adellape: new pull request created: #85261

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #85262

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants