Skip to content

TELCODOCS-1956: Move NVIDIA GPU architecture content to Hardware Acce…#85507

Merged
adellape merged 1 commit intoopenshift:mainfrom
StephenJamesSmith:TELCODOCS-1956
Dec 5, 2024
Merged

TELCODOCS-1956: Move NVIDIA GPU architecture content to Hardware Acce…#85507
adellape merged 1 commit intoopenshift:mainfrom
StephenJamesSmith:TELCODOCS-1956

Conversation

@StephenJamesSmith
Copy link
Contributor

@StephenJamesSmith StephenJamesSmith commented Nov 26, 2024

[TELCODOCS-1956]: Move NVIDIA GPU architecture content to Hardware accelerator overview

This topic has already been reviewed and published and has been moved from the Architecture section to the Hardware accelerators section.. Changes for new technology may be expected.

Jira: https://issues.redhat.com/browse/TELCODOCS-1956

Version(s): openshift-4.17+, openshift-4.16.z

Link to docs preview: https://85507--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_accelerators/nvidia-gpu-architecture

SME: @egallen
QE: @wabouhamad

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.17" instead.

Details

In response to this:

[TELCODOCS-1956]: Move NVIDIA GPU architecture content to Hardware accelerator overview

This topic has been reviewed and published and was in the Architecture section. Changes for new technology expected.

Jira: https://issues.redhat.com/browse/TELCODOCS-1956

Version(s): openshift-4.17+, openshift-4.16.z

Link to docs preview:

SME: @egallen
QE: @bthurber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
include::modules/nvidia-gpu-vsphere.adoc[leveloffset=+3]
[role="_additional-resources"]
.Additional resources
* link:https://docs.nvidia.com/datacenter/cloud-native/gpu-operator/latest/openshift/nvaie-with-ocp.html#openshift-container-platform-on-vmware-vsphere-with-nvidia-vgpus[OpenShift Container Platform on VMware vSphere with NVIDIA vGPUs]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.

include::modules/nvidia-gpu-kvm.adoc[leveloffset=+3]
[role="_additional-resources"]
.Additional resources
* link:https://computingforgeeks.com/how-to-deploy-openshift-container-platform-on-kvm/[How To Deploy OpenShift Container Platform 4.13 on KVM]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.

.Additional resources

* link:https://docs.nvidia.com/ngc/ngc-deploy-on-premises/nvidia-certified-systems/index.html[NVIDIA-Certified Systems]
* link:https://docs.nvidia.com/ai-enterprise/index.html#deployment-guides[NVIDIA AI Enterprise]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] Vale.Avoid: Avoid using 'AI'.

* link:https://docs.nvidia.com/ai-enterprise/index.html#deployment-guides[NVIDIA AI Enterprise]
* link:https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/overview.html#[NVIDIA Container Toolkit]
* link:https://docs.nvidia.com/datacenter/cloud-native/openshift/latest/enable-gpu-monitoring-dashboard.html[Enabling the GPU Monitoring Dashboard]
* link:https://docs.nvidia.com/datacenter/cloud-native/openshift/latest/mig-ocp.html[MIG Support in OpenShift Container Platform]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.17" instead.

Details

In response to this:

[TELCODOCS-1956]: Move NVIDIA GPU architecture content to Hardware accelerator overview

This topic has been reviewed and published and has been moved from the Architecture section. Changes for new technology expected.

Jira: https://issues.redhat.com/browse/TELCODOCS-1956

Version(s): openshift-4.17+, openshift-4.16.z

Link to docs preview: https://85507--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_accelerators/about-hardware-accelerators.html#nvidia-gpu-architecture_about-hardware-accelerators

SME: @egallen
QE: @bthurber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@StephenJamesSmith StephenJamesSmith force-pushed the TELCODOCS-1956 branch 2 times, most recently from 4932764 to 7f2824d Compare November 27, 2024 17:06
include::modules/nvidia-gpu-vsphere.adoc[leveloffset=+2]
[role="_additional-resources"]
.Additional resources
* link:https://docs.nvidia.com/datacenter/cloud-native/gpu-operator/latest/openshift/nvaie-with-ocp.html#openshift-container-platform-on-vmware-vsphere-with-nvidia-vgpus[OpenShift Container Platform on VMware vSphere with NVIDIA vGPUs]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.

include::modules/nvidia-gpu-kvm.adoc[leveloffset=+2]
[role="_additional-resources"]
.Additional resources
* link:https://computingforgeeks.com/how-to-deploy-openshift-container-platform-on-kvm/[How To Deploy OpenShift Container Platform 4.13 on KVM]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.

.Additional resources

* link:https://docs.nvidia.com/ngc/ngc-deploy-on-premises/nvidia-certified-systems/index.html[NVIDIA-Certified Systems]
* link:https://docs.nvidia.com/ai-enterprise/index.html#deployment-guides[NVIDIA AI Enterprise]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] Vale.Avoid: Avoid using 'AI'.

* link:https://docs.nvidia.com/ai-enterprise/index.html#deployment-guides[NVIDIA AI Enterprise]
* link:https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/overview.html#[NVIDIA Container Toolkit]
* link:https://docs.nvidia.com/datacenter/cloud-native/openshift/latest/enable-gpu-monitoring-dashboard.html[Enabling the GPU Monitoring Dashboard]
* link:https://docs.nvidia.com/datacenter/cloud-native/openshift/latest/mig-ocp.html[MIG Support in OpenShift Container Platform]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 27, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.17" instead.

Details

In response to this:

[TELCODOCS-1956]: Move NVIDIA GPU architecture content to Hardware accelerator overview

This topic has been reviewed and published and has been moved from the Architecture section. Changes for new technology expected.

Jira: https://issues.redhat.com/browse/TELCODOCS-1956

Version(s): openshift-4.17+, openshift-4.16.z

Link to docs preview: https://85507--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_accelerators/nvidia-gpu-architecture

SME: @egallen
QE: @bthurber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@StephenJamesSmith StephenJamesSmith changed the title TELCODOCS-1956: Move NVIDIA GPU architecture content to Hardware Acce… [WIP] TELCODOCS-1956: Move NVIDIA GPU architecture content to Hardware Acce… Nov 27, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2024
@egallen
Copy link
Member

egallen commented Nov 27, 2024

LGTM. Feel free to merge.

@bthurber
Copy link

@wabouhamad should be assigned for QE.

@StephenJamesSmith
Copy link
Contributor Author

@wabouhamad Please review and comment/lgtm.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2024

@StephenJamesSmith: This pull request references TELCODOCS-1956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.17" instead.

Details

In response to this:

[TELCODOCS-1956]: Move NVIDIA GPU architecture content to Hardware accelerator overview

This topic has been reviewed and published and has been moved from the Architecture section. Changes for new technology expected.

Jira: https://issues.redhat.com/browse/TELCODOCS-1956

Version(s): openshift-4.17+, openshift-4.16.z

Link to docs preview: https://85507--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_accelerators/nvidia-gpu-architecture

SME: @egallen
QE: @wabouhamad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@StephenJamesSmith
Copy link
Contributor Author

@egallen Wondering if we should add a "Supported hardware" section with a table that lists the supported NVIDIA GPUs and hardware? This table could be updated as needed. WDYT?

Copy link

@wabouhamad wabouhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2024
@StephenJamesSmith
Copy link
Contributor Author

/label telco

@StephenJamesSmith StephenJamesSmith changed the title [WIP] TELCODOCS-1956: Move NVIDIA GPU architecture content to Hardware Acce… TELCODOCS-1956: Move NVIDIA GPU architecture content to Hardware Acce… Dec 4, 2024
@openshift-ci openshift-ci bot added telco Label for all Telco PRs and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 4, 2024
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!


NVIDIA supports the use of graphics processing unit (GPU) resources on {product-title}. {product-title} is a security-focused and hardened Kubernetes platform developed and supported by Red Hat for deploying and managing Kubernetes clusters at scale. {product-title} includes enhancements to Kubernetes so that users can easily configure and use NVIDIA GPU resources to accelerate workloads.

The NVIDIA GPU Operator leverages the Operator framework within {product-title} to manage the full lifecycle of NVIDIA software components required to run GPU-accelerated workloads.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would choose a more accessible word instead of "leverage". Maybe "uses" or "takes advantage of".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

[id="nvidia-gpu-architecture_{context}"]
= NVIDIA GPU architecture

NVIDIA supports the use of graphics processing unit (GPU) resources on {product-title}. {product-title} is a security-focused and hardened Kubernetes platform developed and supported by Red Hat for deploying and managing Kubernetes clusters at scale. {product-title} includes enhancements to Kubernetes so that users can easily configure and use NVIDIA GPU resources to accelerate workloads.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change on this one. The wording was chosen by devs because of unique relationship between OpenShift and partner accelerators.

@lpettyjo lpettyjo added branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 5, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2024

@StephenJamesSmith: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@StephenJamesSmith
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 5, 2024
@adellape adellape self-assigned this Dec 5, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 5, 2024
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

include::modules/nvidia-gpu-csps.adoc[leveloffset=+2]
[role="_additional-resources"]
.Additional resources
* link:https://docs.nvidia.com/ai-enterprise/deployment-guide-cloud/0.1.0/aws-redhat-openshift.html[Red Hat Openshift in the Cloud]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Openshift" (lowercase "S") typo in the destination page is a bummer. :[

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang!

Copy link
Contributor Author

@StephenJamesSmith StephenJamesSmith Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adellape I'm opening another PR on the Accelerators section next week. I can fix this then, if that's ok.

Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adellape adellape merged commit 5446032 into openshift:main Dec 5, 2024
@adellape
Copy link
Contributor

adellape commented Dec 5, 2024

/cherrypick enterprise-4.18

@adellape
Copy link
Contributor

adellape commented Dec 5, 2024

/cherrypick enterprise-4.17

@adellape
Copy link
Contributor

adellape commented Dec 5, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@adellape: new pull request created: #85888

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #85889

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #85890

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files. telco Label for all Telco PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants