Skip to content

DIAGRAMS-527: Added the namespace isolation diagram to UDN docs#87694

Merged
dfitzmau merged 1 commit intoopenshift:mainfrom
dfitzmau:DIAGRAMS-527
Feb 12, 2025
Merged

DIAGRAMS-527: Added the namespace isolation diagram to UDN docs#87694
dfitzmau merged 1 commit intoopenshift:mainfrom
dfitzmau:DIAGRAMS-527

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jan 28, 2025 •
edited
Loading

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:
About user-defined networks

  • SME has approved this change (Surya/Tim).
  • QE has approved this change (Anurag Saxena).

Additional resources:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references DIAGRAMS-527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 28, 2025 •
edited
Loading

🤖 Wed Feb 05 16:07:38 - Prow CI generated the docs preview:

https://87694--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references DIAGRAMS-527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:
About user-defined networks

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the DIAGRAMS-527 branch 2 times, most recently from 7c169df to cdeb8ba Compare January 28, 2025 16:47
@dfitzmau dfitzmau changed the title DIAGRAMS-527: Added the namespace isolation digram to UDN docs DIAGRAMS-527: Added the namespace isolation diagram to UDN docs Jan 29, 2025
@dfitzmau dfitzmau force-pushed the DIAGRAMS-527 branch 2 times, most recently from 4984fb8 to 19146f1 Compare January 31, 2025 11:03
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025
@dfitzmau dfitzmau force-pushed the DIAGRAMS-527 branch 3 times, most recently from 711c5c8 to b71660e Compare February 4, 2025 11:10
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references DIAGRAMS-527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:
About user-defined networks

  • SME has approved this change (Aniket Bhat).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references DIAGRAMS-527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:
About user-defined networks

  • SME has approved this change (Surya/Tim).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tssurya
tssurya approved these changes Feb 5, 2025
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references DIAGRAMS-527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:
About user-defined networks

  • SME has approved this change (Surya/Tim).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references DIAGRAMS-527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:
About user-defined networks

  • SME has approved this change (Surya/Tim).
  • QE has approved this change.

Additional resources:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx
Copy link
Contributor

max-cx commented Feb 5, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 5, 2025
@max-cx
Copy link
Contributor

max-cx commented Feb 5, 2025

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 5, 2025
gabriel-rh
gabriel-rh approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great writing for what is a complex topic @dfitzmau - only one, optional suggestion:

This piece is a little hard to parse, when reading:

by enabling isolated-by-default custom Layer 2, Layer 3, and localnet network segments.

Maybe add a comma after isolated-by-default, or move that to the end?

by enabling custom Layer 2, Layer 3, and localnet network segments, that are isolated by default.

@gabriel-rh gabriel-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references DIAGRAMS-527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:
About user-defined networks

  • SME has approved this change (Surya/Tim).
  • QE has approved this change (Anurag Saxena).

Additional resources:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anuragthehatter
Copy link

anuragthehatter commented Feb 10, 2025

We have undergone various changes. New changes looks good to me.

/lgtm

cc @tssurya as wwell

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references DIAGRAMS-527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+

Issue: DIAGRAMS-527

Link to docs preview:
About user-defined networks

  • SME has approved this change (Surya/Tim).
  • QE has approved this change (Anurag Saxena).

Additional resources:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhradilek
Copy link
Contributor

jhradilek commented Feb 11, 2025

Hi @dfitzmau, I've reviewed the updated diagram and it looks good to me.

@dfitzmau dfitzmau merged commit c453d07 into openshift:main Feb 12, 2025
2 checks passed
@dfitzmau
Copy link
Contributor Author

dfitzmau commented Feb 12, 2025

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 12, 2025

@dfitzmau: new pull request created: #88456

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 12, 2025
Merged
This was referenced Mar 3, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabriel-rh gabriel-rh gabriel-rh approved these changes

@weliang1 weliang1 Awaiting requested review from weliang1

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

+1 more reviewer

@tssurya tssurya tssurya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anuragthehatter anuragthehatter

Labels

branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @max-cx @anuragthehatter @jhradilek @openshift-cherrypick-robot @tssurya @gabriel-rh