Skip to content

CNV-55734: NNS topology view RN#88494

Merged
stevsmit merged 1 commit intoopenshift:enterprise-4.18from
sbeskin-redhat:CNV_55734_NNS_topology_view
Feb 20, 2025
Merged

CNV-55734: NNS topology view RN#88494
stevsmit merged 1 commit intoopenshift:enterprise-4.18from
sbeskin-redhat:CNV_55734_NNS_topology_view

Conversation

@sbeskin-redhat
Copy link
Contributor

@sbeskin-redhat sbeskin-redhat commented Feb 12, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 12, 2025 •
edited by openshift-ci bot
Loading

@sbeskin-redhat: This pull request references CNV-55734 which is a valid jira issue.

Details

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-55734

OCP 4.18
CNV 4.18

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 12, 2025 •
edited
Loading

🤖 Thu Feb 20 14:32:34 - Prow CI generated the docs preview:

https://88494--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html
https://88494--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-18-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 12, 2025 •
edited by openshift-ci bot
Loading

@sbeskin-redhat: This pull request references CNV-55734 which is a valid jira issue.

Details

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-55734

OCP 4.18
CNV 4.18

Preview: https://88494--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-18-release-notes#virt-4-18-technology-preview_virt-4-18-release-notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sbeskin-redhat sbeskin-redhat force-pushed the CNV_55734_NNS_topology_view branch 3 times, most recently from 66ed2c2 to 9bf10b6 Compare February 19, 2025 13:48
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025 •
edited by openshift-ci bot
Loading

@sbeskin-redhat: This pull request references CNV-55734 which is a valid jira issue.

Details

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-55734

OCP 4.18
CNV 4.18

Preview: https://88494--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-18-release-notes.html#virt-4-18-technology-preview_virt-4-18-release-notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sbeskin-redhat sbeskin-redhat force-pushed the CNV_55734_NNS_topology_view branch 2 times, most recently from 55b603c to a334b8c Compare February 20, 2025 09:59
@sbeskin-redhat
Copy link
Contributor Author

sbeskin-redhat commented Feb 20, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 20, 2025
@JoeAldinger JoeAldinger added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 20, 2025
@aspauldi
Copy link

aspauldi commented Feb 20, 2025

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 20, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2025

@aspauldi: Those labels are not set on the issue: peer-review-needed

Details

In response to this:

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbeskin-redhat
Copy link
Contributor Author

sbeskin-redhat commented Feb 20, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 20, 2025
JoeAldinger
JoeAldinger reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing

@sbeskin-redhat sbeskin-redhat force-pushed the CNV_55734_NNS_topology_view branch from 2bee732 to cf0994a Compare February 20, 2025 14:10
@sbeskin-redhat
Copy link
Contributor Author

sbeskin-redhat commented Feb 20, 2025

/label merge-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2025

@sbeskin-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.18 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 20, 2025
@stevsmit stevsmit added this to the Planned for 4.18 GA milestone Feb 20, 2025
@stevsmit stevsmit added lgtm Indicates that a PR is ready to be merged. and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Feb 20, 2025
@stevsmit stevsmit merged commit bdfdbc7 into openshift:enterprise-4.18 Feb 20, 2025
2 checks passed
@ousleyp ousleyp mentioned this pull request Sep 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeAldinger JoeAldinger JoeAldinger left review comments

+1 more reviewer

@lkladnit lkladnit lkladnit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.18 GA

Development

Successfully merging this pull request may close these issues.

7 participants

@sbeskin-redhat @openshift-ci-robot @ocpdocs-previewbot @aspauldi @lkladnit @JoeAldinger @stevsmit