Skip to content

Update the steps for restricting build strategies to a user within a …#89030

Merged
xenolinux merged 1 commit intoopenshift:mainfrom
amrin101:patch-3
Mar 4, 2025
Merged

Update the steps for restricting build strategies to a user within a …#89030
xenolinux merged 1 commit intoopenshift:mainfrom
amrin101:patch-3

Conversation

@amrin101
Copy link
Contributor

@amrin101 amrin101 commented Feb 21, 2025 •
edited
Loading

Removed the pre-requisite as that was not required.

Incorrect Pre-requisite steps for Restricting build strategies to a user within a project

Version(s):

4.15+

Issue:

https://issues.redhat.com/browse/OSDOCS-13019

Link to docs preview:

https://89030--ocpdocs-pr.netlify.app/openshift-enterprise/latest/cicd/builds/securing-builds-by-strategy.html#builds-restricting-build-strategy-to-user_securing-builds-by-strategy

QE review:

  • QE has approved this change.

Additional information:

@amrin101
Update the steps for restricting build strategies to a user within a …
31252fd 
…project

Update the steps for restricting build strategies to a user within a project
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2025

Hi @amrin101. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 21, 2025
@xenolinux xenolinux added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Feb 26, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 26, 2025

🤖 Wed Feb 26 10:43:35 - Prow CI generated the docs preview:

https://89030--ocpdocs-pr.netlify.app/openshift-enterprise/latest/cicd/builds/securing-builds-by-strategy.html

@openshift-ci
Copy link

openshift-ci bot commented Feb 26, 2025

@amrin101: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux added peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.15 branch/enterprise-4.16 labels Feb 26, 2025
xenolinux
xenolinux reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

  • Added the preview link and updated version as 4.15+ (as per the linked Jira) in the comment 0.
  • Added labels for 4.15+ branches as per the Jira details.
  • Provided the peer review for this PR hence, adding the peer-review-done label.

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 26, 2025
@amrin101
Copy link
Contributor Author

amrin101 commented Feb 27, 2025

Could someone kindly perform a QE review?

@amrin101
Copy link
Contributor Author

amrin101 commented Feb 27, 2025

@shipsing ??

@shipsing
Copy link
Contributor

shipsing commented Feb 27, 2025

@adambkaplan @avinal @sayan-biswas, Could any of you review the PR? Thanks

adambkaplan
adambkaplan approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@amrin101
Copy link
Contributor Author

amrin101 commented Mar 3, 2025

/merge-review-needed

@amrin101
Copy link
Contributor Author

amrin101 commented Mar 4, 2025

Can someone please review this merge request ?/

@shipsing
Copy link
Contributor

shipsing commented Mar 4, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 4, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 4, 2025
xenolinux
xenolinux reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging

@xenolinux xenolinux merged commit d7cd95e into openshift:main Mar 4, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 4, 2025
@xenolinux
Copy link
Contributor

xenolinux commented Mar 4, 2025

/cherrypick enterprise-4.15

@xenolinux
Copy link
Contributor

xenolinux commented Mar 4, 2025

/cherrypick enterprise-4.16

@xenolinux
Copy link
Contributor

xenolinux commented Mar 4, 2025

/cherrypick enterprise-4.17

@xenolinux
Copy link
Contributor

xenolinux commented Mar 4, 2025

/cherrypick enterprise-4.18

@xenolinux
Copy link
Contributor

xenolinux commented Mar 4, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 4, 2025

@xenolinux: new pull request created: #89506

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 4, 2025

@xenolinux: new pull request created: #89507

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 4, 2025

@xenolinux: new pull request created: #89508

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 4, 2025

@xenolinux: new pull request created: #89509

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 4, 2025

@xenolinux: new pull request created: #89510

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

@adambkaplan adambkaplan adambkaplan approved these changes

Assignees

@adambkaplan adambkaplan

Labels

branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@amrin101 @ocpdocs-previewbot @shipsing @xenolinux @openshift-cherrypick-robot @adambkaplan