OCPBUGS50980 Need to make changes in the garbage collection documentation#89161
Conversation
openshift-ci
bot
added
the
size/XS
|
🤖 Mon Mar 03 14:32:19 - Prow CI generated the docs preview: https://89161--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/nodes/nodes-nodes-garbage-collection.html |
|
@lyman9966 Please work on this. |
| <9> For image garbage collection: The percent of disk usage (expressed as an integer) that triggers image garbage collection. | ||
| <10> For image garbage collection: The percent of disk usage (expressed as an integer) that image garbage collection attempts to free. | ||
| <9> For image garbage collection: The percent of disk usage (expressed as an integer) that triggers image garbage collection. This value must be greater than the `imageGCLowThresholdPercent` value. | ||
| <10> For image garbage collection: The percent of disk usage (expressed as an integer) that image garbage collection attempts to free. This value must be less than the `imageGCHighThresholdPercent` value. |
There was a problem hiding this comment.
I think it's more correct to modify as:
<10> For image garbage collection: The percent of disk usage (expressed as an integer), to which image garbage collection attempts to free
It means image garbage collection attempts to free the disk usage to this value.
|
/lgtm |
mburke5678
force-pushed
the
nodes-garbage-collect-fix
branch
from
0cc6e65 to
c82d93e
Compare
|
New changes are detected. LGTM label has been removed. |
mburke5678
added
the
peer-review-needed
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label peer-review-in-progress |
openshift-ci
bot
added
peer-review-in-progress
mramendi
left a comment
mramendi
left a comment
There was a problem hiding this comment.
A few peer review nits, fine otherwise, great work
| <8> For image garbage collection: The minimum age for an unused image before the image is removed by garbage collection. | ||
| <9> For image garbage collection: The percent of disk usage (expressed as an integer) that triggers image garbage collection. | ||
| <10> For image garbage collection: The percent of disk usage (expressed as an integer) that image garbage collection attempts to free. | ||
| <9> For image garbage collection: Image garbage collection is triggered at the specified percent of disk usage (expressed as an integer). This value must be greater than the `imageGCLowThresholdPercent` value. |
There was a problem hiding this comment.
Why did you change active voice to passive voice? "Percentage of disk usage (expressed as an integer) that triggers the image garbage collection" looks better to me, though it's your call. The new sentence is fine.
There was a problem hiding this comment.
@mramendi I changed this one to make the language parallel with <10>.
| <9> For image garbage collection: The percent of disk usage (expressed as an integer) that triggers image garbage collection. | ||
| <10> For image garbage collection: The percent of disk usage (expressed as an integer) that image garbage collection attempts to free. | ||
| <9> For image garbage collection: Image garbage collection is triggered at the specified percent of disk usage (expressed as an integer). This value must be greater than the `imageGCLowThresholdPercent` value. | ||
| <10> For image garbage collection: Image garbage collection attempts to free resources to the specified percent of disk usage (expressed as an integer). This value must be less than the `imageGCHighThresholdPercent` value. |
There was a problem hiding this comment.
It is not entirely clear if this means that (a) it aims to have the remaining usage of this percent or (b) it attempts to free this percent (so in the example, to free 75% of the disk, leaving 25% used).
The previous formula reads as (b). I suspect the true reading is (a). Ideally, if you don't have this answer handy, could you possibly find out from the SMEs and then clarify the text?
There was a problem hiding this comment.
@mramendi
According to QE:
It means image garbage collection attempts to free the disk usage to this value.
| |`imageGCLowThresholdPercent` | ||
| |The percent of disk usage, expressed as an integer, to which image garbage | ||
| collection attempts to free. The default is *80*. | ||
| collection attempts to free. The default is *80*. This value must be less than the `imageGCHighThresholdPercent` value. |
There was a problem hiding this comment.
"must be smaller than", I'd suggest.
|
/label peer-review-done |
openshift-ci
bot
added
peer-review-done
|
/cherrypick enterprise-4.12 |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
@mburke5678: new pull request created: #89903 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #89904 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #89905 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #89906 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #89907 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #89908 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #89909 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.19 |
|
@mburke5678: new pull request created: #89911 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
https://issues.redhat.com/browse/OCPBUGS-50980
mention that the
imageGCHighThresholdPercentandimageGCLowThresholdPercentshould have different values, when they are provided with the same values the kubelet crashes and node goes to NotReady state.QE review: