OSDOCS10896: Update Custom Metrics Autoscaler documentation for ClusterTriggerAuthentication implementation#89402
Conversation
openshift-ci
bot
added
the
size/M
| ---- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| kind: RoleBinding <1> |
There was a problem hiding this comment.
Thoughts on this being <binding type> vs literal RoleBinding, so the user is forced to make a decision based on their situation?
|
@prozehna Can you PTAL for QE. Thanks in advance! |
|
At first check looks good, let me take a second one for my final comments. |
@prozehna Any further thoughts? |
|
Apologies I didn't get back to you sooner. I can't find any issues nor nits. |
mburke5678
force-pushed
the
podauto-custom-trig-auth
branch
from
fbb3523 to
9d7e570
Compare
|
New changes are detected. LGTM label has been removed. |
mburke5678
added
the
peer-review-needed
jldohmann
added
the
peer-review-in-progress
jldohmann
left a comment
jldohmann
left a comment
There was a problem hiding this comment.
mostly LGTM, just some clarification comments and nits below
|
|
||
| You can use the installed {product-title} Prometheus monitoring as a source for the metrics used by the custom metrics autoscaler. However, there are some additional configurations you must perform. | ||
|
|
||
| For your scaled objects to be able to read the {product-title} Prometheus metrics, you must use a trigger authentication or a cluster trigger authentication in order to provide the authentication information required. The following procedure differs depending on which trigger authentication method you use. For more information on trigger authentications, see "Understanding custom metrics autoscaler trigger authentications". |
There was a problem hiding this comment.
can you add somewhere before the procedure that it is using the trigger authentication method? unless it's not, but based on the information contained in some of the codeblocks within the procedure that seems to be the case
There was a problem hiding this comment.
Made the procedure generic, for both auth methods.
| * If you are using a trigger authentication, specify `TriggerAuthentication`. | ||
| * If you are using a cluster trigger authentication, specify `ClusterTriggerAuthentication`. | ||
| + | ||
| <2> Specifies that thi s object uses a secret for authorization. |
There was a problem hiding this comment.
| <2> Specifies that thi s object uses a secret for authorization. | |
| <2> Specifies that this object uses a secret for authorization. |
| ---- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| kind: <binding_type> <1> |
There was a problem hiding this comment.
based on the other portions of this procedure where you are using TriggerAuthentication method parameters, i think it makes sense to stick with RoleBinding to be consistent
jldohmann
added
peer-review-done
…erTriggerAuthentication implementation
mburke5678
force-pushed
the
podauto-custom-trig-auth
branch
from
9d7e570 to
4b737f5
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.19 |
|
@mburke5678: new pull request created: #90016 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #90017 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #90018 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #90019 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #90020 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mburke5678: new pull request created: #90021 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
https://issues.redhat.com/browse/OSDOCS-10896
Preview:
Configuring the custom metrics autoscaler to use OpenShift Container Platform monitoring -- Myriad changes, including:
QE review: