Skip to content

OSDOCS-4486: add Azure AZ warning in MAPI compute spec#89658

Merged
jeana-redhat merged 1 commit intoopenshift:mainfrom
jeana-redhat:OSDOCS-4486-add-azure-zone-warning
Mar 6, 2025
Merged

OSDOCS-4486: add Azure AZ warning in MAPI compute spec#89658
jeana-redhat merged 1 commit intoopenshift:mainfrom
jeana-redhat:OSDOCS-4486-add-azure-zone-warning

Conversation

@jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Mar 5, 2025

Version(s):
4.12+

Issue:
OSDOCS-4486

Link to docs preview:
Sample YAML for a compute machine set custom resource on Azure

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2025

@jeana-redhat: This pull request references OSDOCS-4486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.12+

Issue:
OSDOCS-4486

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

2 similar comments
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2025

@jeana-redhat: This pull request references OSDOCS-4486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.12+

Issue:
OSDOCS-4486

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2025

@jeana-redhat: This pull request references OSDOCS-4486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.12+

Issue:
OSDOCS-4486

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2025

@jeana-redhat: This pull request references OSDOCS-4486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.12+

Issue:
OSDOCS-4486

Link to docs preview:
Sample YAML for a compute machine set custom resource on Azure

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2025

@jeana-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2025

@jeana-redhat: This pull request references OSDOCS-4486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.12+

Issue:
OSDOCS-4486

Link to docs preview:
Sample YAML for a compute machine set custom resource on Azure

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@shellyyang1989
Copy link

cc @sunzhaohua2

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunzhaohua2
Copy link

/lgtm
I tested on 4.19, create machine without defining zone, create pvc and pod, though the zone between node labels and pv affinity are not match, pod can be deployed succeed. But I think this warning is valid, before we had a similar bug about region's mistmatch between node labels and pv affinity. https://bugzilla.redhat.com/show_bug.cgi?id=1860128

$ oc get machine                                                          
NAME                                         PHASE     TYPE              REGION   ZONE   AGE
kataci06123718-fqb9h-master-0                Running   Standard_D8s_v3   eastus   2      6h
kataci06123718-fqb9h-master-1                Running   Standard_D8s_v3   eastus   3      6h
kataci06123718-fqb9h-master-2                Running   Standard_D8s_v3   eastus   1      6h
kataci06123718-fqb9h-worker-eastus2-7psgt    Running   Standard_D4s_v3   eastus   2      5h54m
kataci06123718-fqb9h-worker-eastus3-j7jlz    Running   Standard_D4s_v3   eastus   3      5h54m
kataci06123718-fqb9h-worker-eastus33-gdshv   Running   Standard_D4s_v3   eastus          171m
$ oc get po                                                       
task-pv-pod                                           1/1     Running   0          7m35s
$ oc get node kataci06123718-fqb9h-worker-eastus33-gdshv -o yaml
    topology.kubernetes.io/region: eastus
    topology.kubernetes.io/zone: "0"
 $ oc get pv pvc-60eeb887-1391-40e6-986d-aafb88093512 -o yaml
  nodeAffinity:
    required:
      nodeSelectorTerms:
      - matchExpressions:
        - key: topology.disk.csi.azure.com/zone
          operator: In
          values:
          - ""

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@jeana-redhat jeana-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2025

@jeana-redhat: This pull request references OSDOCS-4486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.12+

Issue:
OSDOCS-4486

Link to docs preview:
Sample YAML for a compute machine set custom resource on Azure

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 6, 2025
@lpettyjo lpettyjo self-requested a review March 6, 2025 14:44
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 6, 2025
@jeana-redhat jeana-redhat merged commit 9884ba0 into openshift:main Mar 6, 2025
2 checks passed
@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.19

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.18

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.17

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.16

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.15

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.14

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.13

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #89766

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #89767

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #89768

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #89769

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #89770

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #89771

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #89772

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #89773

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants