Skip to content

CNV-57530: Add notes about unsupported snapshots#89765

Merged
xenolinux merged 1 commit intoopenshift:enterprise-4.17from
jhradilek:CNV-57530-unsupported-snapshots
Mar 13, 2025
Merged

CNV-57530: Add notes about unsupported snapshots#89765
xenolinux merged 1 commit intoopenshift:enterprise-4.17from
jhradilek:CNV-57530-unsupported-snapshots

Conversation

@jhradilek
Copy link
Contributor

@jhradilek jhradilek commented Mar 6, 2025 •
edited
Loading

Version(s): 4.14, 4.15, 4.16, 4.17

Issue: CNV-57530

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Support for creating snapshots for VMs with a vTPM device has been added in 4.18. This pull request builds on the notes introduced to 4.18 with PR #88581 and backports a variation of this info to the remaining supported releases.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2025 •
edited by openshift-ci bot
Loading

@jhradilek: This pull request references CNV-57530 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17

Issue: CNV-57530

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Support for creating snapshots for VMs with a vTPM device has been added in 4.18. This pull request builds on the notes introduced to 4.18 with PR #88581 and backports a variation of this info to the remaining supported releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2025
@jhradilek
Copy link
Contributor Author

jhradilek commented Mar 6, 2025

/label cnv

@openshift-ci openshift-ci bot added CNV Label for all CNV PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 6, 2025 •
edited
Loading

🤖 Wed Mar 12 15:56:50 - Prow CI generated the docs preview:

https://89765--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/creating_vms_custom/virt-cloning-vms.html
https://89765--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-using-vtpm-devices.html
https://89765--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/virtual_machines/creating_vms_custom/virt-cloning-vms.html
https://89765--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/virtual_machines/virt-using-vtpm-devices.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2025 •
edited by openshift-ci bot
Loading

@jhradilek: This pull request references CNV-57530 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17

Issue: CNV-57530

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Support for creating snapshots for VMs with a vTPM device has been added in 4.18. This pull request builds on the notes introduced to 4.18 with PR #88581 and backports a variation of this info to the remaining supported releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alromeros
Copy link

alromeros commented Mar 7, 2025

Looks good!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2025
@jhradilek
Copy link
Contributor Author

jhradilek commented Mar 10, 2025

Thank you.

/label peer-review-needed

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025 •
edited by openshift-ci bot
Loading

@jhradilek: This pull request references CNV-57530 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17

Issue: CNV-57530

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Support for creating snapshots for VMs with a vTPM device has been added in 4.18. This pull request builds on the notes introduced to 4.18 with PR #88581 and backports a variation of this info to the remaining supported releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 10, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 10, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Mar 10, 2025
xenolinux
xenolinux reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment; overall LGTM

virt/virtual_machines/virt-using-vtpm-devices.adoc Outdated

[IMPORTANT]
====
Cloning of virtual machines (VMs) with a vTPM device or creating snapshots of such VMs is not supported. Support for creating snapshots of VMs with vTPM devices has been added in {VirtProductName} 4.18.
Copy link
Contributor

@xenolinux xenolinux Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cloning of virtual machines (VMs) with a vTPM device or creating snapshots of such VMs is not supported. Support for creating snapshots of VMs with vTPM devices has been added in {VirtProductName} 4.18.
Cloning or creating snapshots of virtual machines (VMs) with a vTPM device is not supported. Support for creating snapshots of VMs with vTPM devices is added in {VirtProductName} 4.18.

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 10, 2025
@jhradilek jhradilek force-pushed the CNV-57530-unsupported-snapshots branch from 1c1e889 to da47ca3 Compare March 11, 2025 13:25
@jhradilek
Copy link
Contributor Author

jhradilek commented Mar 11, 2025 •
edited
Loading

Thank you, I like your suggestion and pushed a new version with it applied.

@jhradilek
Copy link
Contributor Author

jhradilek commented Mar 12, 2025

/retest

@jhradilek
Copy link
Contributor Author

jhradilek commented Mar 12, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Mar 12, 2025

@jhradilek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux merged commit 855fd2e into openshift:enterprise-4.17 Mar 13, 2025
2 checks passed
@xenolinux xenolinux added branch/enterprise-4.17 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 13, 2025
@xenolinux
Copy link
Contributor

xenolinux commented Mar 13, 2025

/cherrypick enterprise-4.14

@xenolinux
Copy link
Contributor

xenolinux commented Mar 13, 2025

/cherrypick enterprise-4.15

@xenolinux
Copy link
Contributor

xenolinux commented Mar 13, 2025

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 13, 2025

@xenolinux: #89765 failed to apply on top of branch "enterprise-4.14":

Applying: CNV-57530: Added notes about unsupported snapshots
Using index info to reconstruct a base tree...
A	virt/virtual_machines/creating_vms_custom/virt-cloning-vms.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): virt/virtual_machines/creating_vms_custom/virt-cloning-vms.adoc deleted in HEAD and modified in CNV-57530: Added notes about unsupported snapshots. Version CNV-57530: Added notes about unsupported snapshots of virt/virtual_machines/creating_vms_custom/virt-cloning-vms.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-57530: Added notes about unsupported snapshots
Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 13, 2025

@xenolinux: new pull request created: #90189

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Mar 13, 2025
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 13, 2025

@xenolinux: new pull request created: #90190

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xenolinux
Copy link
Contributor

xenolinux commented Mar 13, 2025

#89765 (comment) Automated CP PR for 4.14 failed, manual CP PR is needed for 4.14.

@jhradilek jhradilek deleted the CNV-57530-unsupported-snapshots branch March 13, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

+1 more reviewer

@jpeimer jpeimer jpeimer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alromeros alromeros

Labels

branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@jhradilek @openshift-ci-robot @ocpdocs-previewbot @alromeros @xenolinux @openshift-cherrypick-robot @jpeimer