Skip to content

OBSDOCS-1327: Add a link to the test alert KCS#93204

Merged
xenolinux merged 1 commit intoopenshift:mainfrom
eromanova97:OBSDOCS-1327
May 15, 2025
Merged

OBSDOCS-1327: Add a link to the test alert KCS#93204
xenolinux merged 1 commit intoopenshift:mainfrom
eromanova97:OBSDOCS-1327

Conversation

@eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented May 12, 2025 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 12, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1327 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.14 +

Issue: https://issues.redhat.com/browse/OBSDOCS-1327

Link to docs preview:

QE review: n/a

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 12, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 12, 2025

🤖 Mon May 12 09:01:01 - Prow CI generated the docs preview:

https://93204--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-core-platform-monitoring/configuring-alerts-and-notifications.html
https://93204--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-user-workload-monitoring/configuring-alerts-and-notifications-uwm.html

@openshift-ci
Copy link

openshift-ci bot commented May 12, 2025

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 12, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1327 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.14 +

Issue: https://issues.redhat.com/browse/OBSDOCS-1327

Link to docs preview:

QE review: n/a

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

eromanova97 commented May 14, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 14, 2025
@tmalove
Copy link
Contributor

tmalove commented May 14, 2025

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 14, 2025
tmalove
tmalove reviewed May 14, 2025
View reviewed changes
...ty/monitoring/configuring-core-platform-monitoring/configuring-alerts-and-notifications.adoc
[role="_additional-resources"]
.Additional resources

* link:https://access.redhat.com/solutions/6828481[Send test alerts to Alertmanager in OpenShift 4] (Red{nbsp}Hat Customer Portal)
Copy link
Contributor

@tmalove tmalove May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your consideration...is it necessary to add the notice that the link is on the portal?

Copy link
Contributor Author

@eromanova97 eromanova97 May 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, this is something I am currently not sure of myself, because from the OCP side there was a push to explicitly say that the link is external by using this format, but then it can also possibly cause some rendering issues down the line (so there seem to be two conflicting pieces of information ATM), I left it like this to be consistent with the rest of the docs here, but I am evaluating if these clarifications should be removed altogether.

Thank you for checking!

@tmalove
Copy link
Contributor

tmalove commented May 14, 2025

/remove-label peer-review-in-progress
/label peer-review-done

I added a question about the link...otherwise lgtm.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 14, 2025
@eromanova97
Copy link
Contributor Author

eromanova97 commented May 15, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 15, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 15, 2025
@xenolinux xenolinux added this to the Continuous Release milestone May 15, 2025
xenolinux
xenolinux reviewed May 15, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging

@xenolinux xenolinux merged commit 5829112 into openshift:main May 15, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 15, 2025
@xenolinux
Copy link
Contributor

xenolinux commented May 15, 2025

/cherrypick enterprise-4.14

@xenolinux
Copy link
Contributor

xenolinux commented May 15, 2025

/cherrypick enterprise-4.15

@xenolinux
Copy link
Contributor

xenolinux commented May 15, 2025

/cherrypick enterprise-4.16

@xenolinux
Copy link
Contributor

xenolinux commented May 15, 2025

/cherrypick enterprise-4.17

@xenolinux
Copy link
Contributor

xenolinux commented May 15, 2025

/cherrypick enterprise-4.18

@xenolinux
Copy link
Contributor

xenolinux commented May 15, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 15, 2025

@xenolinux: new pull request created: #93397

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 15, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 15, 2025

@xenolinux: new pull request created: #93398

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced May 15, 2025
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 15, 2025

@xenolinux: new pull request created: #93399

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 15, 2025

@xenolinux: new pull request created: #93400

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 15, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 15, 2025

@xenolinux: new pull request created: #93401

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 15, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 15, 2025

@xenolinux: new pull request created: #93402

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 15, 2025
Merged
@eromanova97 eromanova97 deleted the OBSDOCS-1327 branch May 15, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

+1 more reviewer

@tmalove tmalove tmalove left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @tmalove @xenolinux @openshift-cherrypick-robot