Skip to content

OCPBUGS-53450:NFS export options for Filestore SC#94199

Merged
lpettyjo merged 1 commit intoopenshift:mainfrom
lpettyjo:OCPBUGS-53450
Jun 10, 2025
Merged

OCPBUGS-53450:NFS export options for Filestore SC#94199
lpettyjo merged 1 commit intoopenshift:mainfrom
lpettyjo:OCPBUGS-53450

Conversation

@lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Jun 3, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 3, 2025

@lpettyjo: This pull request references Jira Issue OCPBUGS-53450, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2025
@lpettyjo lpettyjo requested a review from gnufied June 3, 2025 18:18
@lpettyjo lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 3, 2025
@lpettyjo lpettyjo added this to the Planned for 4.19 GA milestone Jun 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 3, 2025

@lpettyjo: This pull request references Jira Issue OCPBUGS-53450, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s): 4.19+

Issue: https://issues.redhat.com/browse/OCPBUGS-53450

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

PTAL: @duanwei33 @gnufied @gcharot @rhrmo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 3, 2025 •
edited
Loading

🤖 Fri Jun 06 16:03:01 - Prow CI generated the docs preview:

https://94199--ocpdocs-pr.netlify.app/openshift-dedicated/latest/storage/container_storage_interface/persistent-storage-csi-google-cloud-file.html
https://94199--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-google-cloud-file.html

@gnufied
Copy link
Member

gnufied commented Jun 3, 2025

/assign @RomanBednar

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 4, 2025
xenolinux
xenolinux reviewed Jun 4, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits; otherwise LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 4, 2025
@duanwei33
Copy link

duanwei33 commented Jun 4, 2025

@chao007 Could you please take a look at this？

chao007
chao007 reviewed Jun 5, 2025
View reviewed changes
gcharot
gcharot reviewed Jun 5, 2025
View reviewed changes
gcharot
gcharot reviewed Jun 5, 2025
View reviewed changes
@RomanBednar
Copy link

RomanBednar commented Jun 6, 2025

/assign @RomanBednar

@gnufied I've posted a few comments but I don't have any more context on this feature, unassigning.

@RomanBednar RomanBednar removed their assignment Jun 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhrmo
Copy link

rhrmo commented Jun 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@gnufied
Copy link
Member

gnufied commented Jun 9, 2025

lgtm

1 similar comment
@chao007
Copy link

chao007 commented Jun 10, 2025

lgtm

@gcharot
Copy link

gcharot commented Jun 10, 2025

LGTM

@lpettyjo lpettyjo merged commit de1237c into openshift:main Jun 10, 2025
2 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@lpettyjo: Jira Issue OCPBUGS-53450 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Version(s): 4.19+

Issue: https://issues.redhat.com/browse/OCPBUGS-53450

Link to docs preview: https://94199--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-google-cloud-file.html#persistent-storage-csi-gcp-filestore-nfs-export-options_persistent-storage-csi-google-cloud-file

QE review:

  • QE has approved this change.

Additional information:

PTAL: @chao007 @gnufied @gcharot @rhrmo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lpettyjo
Copy link
Contributor Author

lpettyjo commented Jun 10, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 10, 2025

@lpettyjo: new pull request created: #94502

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

@gnufied gnufied Awaiting requested review from gnufied

+5 more reviewers

@gcharot gcharot gcharot left review comments

@RomanBednar RomanBednar RomanBednar left review comments

@chao007 chao007 chao007 left review comments

@rhrmo rhrmo rhrmo left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhrmo rhrmo

Labels

branch/enterprise-4.19 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Planned for 4.19 GA

Development

Successfully merging this pull request may close these issues.