Skip to content

OSDOCS#12350: Migrate etcd performance content to new etcd book#94521

Merged
lahinson merged 1 commit intoopenshift:mainfrom
kowen-rh:osdocs-12350
Jun 11, 2025
Merged

OSDOCS#12350: Migrate etcd performance content to new etcd book#94521
lahinson merged 1 commit intoopenshift:mainfrom
kowen-rh:osdocs-12350

Conversation

@kowen-rh
Copy link
Contributor

@kowen-rh kowen-rh commented Jun 10, 2025 •
edited
Loading

Version(s):
4.19+

Issue:
OSDOCS-12350

Link to docs preview:
Performance considerations for etcd
Recommended etcd practices

QE review:

  • QE has approved this change.

Additional information:

N/A

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 10, 2025 •
edited
Loading

🤖 Wed Jun 11 16:13:32 - Prow CI generated the docs preview:
https://94521--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

lahinson
lahinson reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted 2 xrefs that aren't working. I think if you can fix those, the tests will pass.

@lahinson lahinson added this to the Planned for 4.19 GA milestone Jun 10, 2025
@kowen-rh
Copy link
Contributor Author

kowen-rh commented Jun 10, 2025

/retest

@geliu2016
Copy link

geliu2016 commented Jun 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@kowen-rh
Copy link
Contributor Author

kowen-rh commented Jun 11, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 11, 2025
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 11, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 11, 2025
bergerhoffer
bergerhoffer reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two things, otherwise LGTM!

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 11, 2025

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 11, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025

@kowen-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kowen-rh
Copy link
Contributor Author

kowen-rh commented Jun 11, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 11, 2025
@lahinson lahinson added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 11, 2025
lahinson
lahinson reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for merging. Thanks so much for your work on this, @kowen-rh!

@lahinson lahinson merged commit 3a673f7 into openshift:main Jun 11, 2025
2 checks passed
@lahinson
Copy link
Contributor

lahinson commented Jun 11, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 11, 2025

@lahinson: new pull request created: #94610

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@lahinson lahinson lahinson left review comments

Assignees

@geliu2016 geliu2016

Labels

branch/enterprise-4.19 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Planned for 4.19 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@kowen-rh @ocpdocs-previewbot @geliu2016 @bergerhoffer @lahinson @openshift-cherrypick-robot