Skip to content

OSDOCS-15248#combining Azure assemblies#95920

Merged
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
brendan-daly-red-hat:OSDOCS-15248
Sep 18, 2025
Merged

OSDOCS-15248#combining Azure assemblies#95920
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
brendan-daly-red-hat:OSDOCS-15248

Conversation

@brendan-daly-red-hat
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat commented Jul 10, 2025

Versions:
4.20+

Issue:
https://issues.redhat.com/browse/OSDOCS-15248

Link to docs preview:
Modules copied from the assembly 'Installing a cluster on Azure with network customizations' and added to the assembly 'Installing a cluster on Azure with customizations':

Revised this module to include references to network customizations:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 10, 2025

🤖 Thu Sep 18 08:17:47 - Prow CI generated the docs preview:
https://95920--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@brendan-daly-red-hat brendan-daly-red-hat changed the title OSDOCS-15248#combining assemblies OSDOCS-15248#combining Azure assemblies Jul 10, 2025
@brendan-daly-red-hat brendan-daly-red-hat force-pushed the OSDOCS-15248 branch 2 times, most recently from 3c5d410 to 73d9690 Compare July 11, 2025 12:44
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2025
@brendan-daly-red-hat brendan-daly-red-hat force-pushed the OSDOCS-15248 branch 12 times, most recently from e4a11c1 to 384763e Compare July 15, 2025 09:50
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2025
@bscott-rh bscott-rh added this to the Planned for 4.20 GA milestone Jul 15, 2025
Copy link
Contributor

@makentenza makentenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea!

LGTM

@brendan-daly-red-hat
Copy link
Contributor Author

@jinyunma, PTAL

@jinyunma
Copy link

Thanks for the updating. The most part looks good me except below one, seems that 'networking' field is missing in Sample customized install-config.yaml file for Azure.

metadata:
  name: test-cluster 
networking:                ------------------> this field missed!
  clusterNetwork:
  - cidr: 10.128.0.0/14
    hostPrefix: 23
  machineNetwork:
  - cidr: 10.0.0.0/16
  networkType: OVNKubernetes 
  serviceNetwork:
  - 172.30.0.0/16

@brendan-daly-red-hat brendan-daly-red-hat force-pushed the OSDOCS-15248 branch 2 times, most recently from c01fe66 to 46f11f0 Compare July 23, 2025 10:53
@brendan-daly-red-hat
Copy link
Contributor Author

name: test-cluster

Thanks Jinyun Ma. I fixed this so that the 'networking' field is displaying now.

@jinyunma
Copy link

jinyunma commented Aug 4, 2025

LGTM

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2025
@brendan-daly-red-hat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 17, 2025
@ShaunaDiaz ShaunaDiaz added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 17, 2025
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No merge blockers, a few minor notes.

@ShaunaDiaz ShaunaDiaz added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Sep 17, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2025

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit 92db4d6 into openshift:main Sep 18, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #99330

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 ok-to-merge size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants