OSDOCS-15248#combining Azure assemblies#95920
Conversation
|
🤖 Thu Sep 18 08:17:47 - Prow CI generated the docs preview: |
761e642 to
37338aa
Compare
3c5d410 to
73d9690
Compare
e4a11c1 to
384763e
Compare
makentenza
left a comment
There was a problem hiding this comment.
This is a great idea!
LGTM
|
@jinyunma, PTAL |
|
Thanks for the updating. The most part looks good me except below one, seems that 'networking' field is missing in Sample customized install-config.yaml file for Azure. |
c01fe66 to
46f11f0
Compare
Thanks Jinyun Ma. I fixed this so that the 'networking' field is displaying now. |
|
LGTM |
46f11f0 to
e55bb4a
Compare
e55bb4a to
a7db2ad
Compare
|
/label merge-review-needed |
ShaunaDiaz
left a comment
There was a problem hiding this comment.
No merge blockers, a few minor notes.
installing/installing_azure/ipi/installing-azure-customizations.adoc
Outdated
Show resolved
Hide resolved
a7db2ad to
bd1d84c
Compare
bd1d84c to
0e1f7ea
Compare
|
@brendan-daly-red-hat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
@ShaunaDiaz: new pull request created: #99330 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Versions:
4.20+
Issue:
https://issues.redhat.com/browse/OSDOCS-15248
Link to docs preview:
Modules copied from the assembly 'Installing a cluster on Azure with network customizations' and added to the assembly 'Installing a cluster on Azure with customizations':
Revised this module to include references to network customizations:
QE review:
Additional information: