Skip to content

osdocs15216: ContentX improvements for custom PKI doc#96703

Merged
lahinson merged 1 commit intoopenshift:mainfrom
DCChadwick:osdocs15216
Sep 18, 2025
Merged

osdocs15216: ContentX improvements for custom PKI doc#96703
lahinson merged 1 commit intoopenshift:mainfrom
DCChadwick:osdocs15216

Conversation

@DCChadwick
Copy link

@DCChadwick DCChadwick commented Jul 25, 2025 •
edited
Loading

Version(s): 4.20+

Issue: OSDOCS-15216

Link to docs preview: https://96703--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_network_settings/configuring-a-custom-pki.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 25, 2025 •
edited
Loading

🤖 Thu Sep 18 19:12:13 - Prow CI generated the docs preview:

https://96703--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_network_settings/configuring-a-custom-pki.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jul 25, 2025
View reviewed changes
@DCChadwick DCChadwick force-pushed the osdocs15216 branch 3 times, most recently from 9633d2c to d2642d2 Compare August 1, 2025 16:17
jab-rh
jab-rh reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@jab-rh jab-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly need to double check any missing codefont for filenames and YAML property names. I fixed a few, but there are others.

Thanks!

rhamini3
rhamini3 reviewed Sep 4, 2025
View reviewed changes
@DCChadwick
Copy link
Author

DCChadwick commented Sep 10, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 10, 2025
@DCChadwick
Copy link
Author

DCChadwick commented Sep 10, 2025

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 10, 2025
@DCChadwick
Copy link
Author

DCChadwick commented Sep 17, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 17, 2025
@lahinson lahinson added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 18, 2025
lahinson
lahinson reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DCChadwick I spotted a few items for you to address before this one is merged. Thanks!

@lahinson lahinson added this to the Planned for 4.20 GA milestone Sep 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2025

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lahinson
lahinson reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging.

@lahinson lahinson merged commit 4f79e8c into openshift:main Sep 18, 2025
2 checks passed
@lahinson
Copy link
Contributor

lahinson commented Sep 18, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 18, 2025

@lahinson: new pull request created: #99350

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2025
Merged
@lahinson lahinson removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahinson lahinson lahinson left review comments

@jab-rh jab-rh jab-rh left review comments

+2 more reviewers

@rhamini3 rhamini3 rhamini3 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.20 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.20 GA

Development

Successfully merging this pull request may close these issues.

7 participants

@DCChadwick @ocpdocs-previewbot @lahinson @openshift-cherrypick-robot @rhamini3 @jab-rh @ocpdocs-vale-bot