CNV-55995: Host network configuration visualization by sbeskin-redhat · Pull Request #97234 · openshift/openshift-docs

sbeskin-redhat · 2025-08-06T14:20:17Z

Resolves: https://issues.redhat.com/browse/CNV-55995

CNV 4.19+
OCP 4.19+

Preview:
https://97234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html#virt-viewing-network-state-of-node-console_k8s-nmstate-updating-node-network-config
https://97234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html#virt-create-node-network-config-console_k8s-nmstate-updating-node-network-config

openshift-ci-robot · 2025-08-06T14:20:27Z

@sbeskin-redhat: This pull request references CNV-55995 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-55995

CNV 4.20
OCP 4.20

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2025-08-06T14:41:12Z

🤖 Wed Aug 27 18:16:36 - Prow CI generated the docs preview:

https://97234--ocpdocs-pr.netlify.app/
https://97234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html

openshift-ci-robot · 2025-08-06T14:47:42Z

@sbeskin-redhat: This pull request references CNV-55995 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-55995

CNV 4.20
OCP 4.20

Preview:
https://97234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html#virt-viewing-network-state-of-node-console_k8s-nmstate-updating-node-network-config
https://97234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html#virt-create-node-network-config-console_k8s-nmstate-updating-node-network-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-08-06T15:32:02Z

@sbeskin-redhat: This pull request references CNV-55995 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-55995

CNV 4.19+
OCP 4.19+

Preview:
https://97234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html#virt-viewing-network-state-of-node-console_k8s-nmstate-updating-node-network-config
https://97234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.html#virt-create-node-network-config-console_k8s-nmstate-updating-node-network-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lkladnit · 2025-08-11T15:26:10Z

/lgtm

ctomasko · 2025-08-20T14:21:30Z

@sbeskin-redhat all approvals received. This PR is ready to merge.

ousleyp

This is looking pretty good, but there are a few things that must be fixed before you request a merge review. Thanks @sbeskin-redhat! (Ah! And don't forget to squash to one commit.)

modules/virt-create-node-network-config-console.adoc

ousleyp · 2025-08-21T16:01:58Z

modules/virt-create-node-network-config-console.adoc

 .. Enter the name of the interface in *Interface name* field.

-.. Select the network state from *Network state* dropdown. The default selected value is *Up*.
+.. Select the required network state in the *Network state* part of the section. The default selected state is *Up*.


Suggested change

.. Select the required network state in the *Network state* part of the section. The default selected state is *Up*.

.. Select the required network state in the *Network state* list. The default selected state is *Up*.

If it's what we would normally call a "dropdown menu," we use "list"

@ousleyp This is not a dropdown menu and not a list. It's just several radio buttons, and each one selects a state. Maybe just "Select the required network state." would be enough.

ousleyp · 2025-08-21T16:02:15Z

modules/virt-create-node-network-config-console.adoc

+.. Select the required network state in the *Network state* part of the section. The default selected state is *Up*.

-.. Select the type of interface from *Type* dropdown. The available values are *Bridge*, *Bonding*, and *Ethernet*. The default selected value is *Bridge*.
+.. Select the type of interface in the *Type* part of the section. The available types are *Bridge*, *Bonding*, and *Ethernet*. The default selected value is *Bridge*.


Suggested change

.. Select the type of interface in the *Type* part of the section. The available types are *Bridge*, *Bonding*, and *Ethernet*. The default selected value is *Bridge*.

.. Select the type of interface in the *Type* list. The available types are *Bridge*, *Bonding*, and *Ethernet*. The default selected value is *Bridge*.

@ousleyp Same as above.

modules/virt-create-node-network-config-console.adoc

modules/virt-viewing-network-state-of-node-console.adoc

sbeskin-redhat · 2025-08-25T19:48:02Z

@ousleyp Thank you! I made the changes. Please take a look. If it's OK, could you merge it?

ousleyp · 2025-08-25T20:26:40Z

@ousleyp Thank you! I made the changes. Please take a look. If it's OK, could you merge it?

Hi @sbeskin-redhat, please remove backup_and_restore/build/en-US/master.xml from your PR before requesting merge review. Looks like that was accidentally added somehow. :)

sbeskin-redhat · 2025-08-26T18:51:29Z

@ousleyp Done

ousleyp

A few nits, but otherwise it's looking good.

modules/virt-viewing-graphical-representation-of-network-state-of-node-console.adoc

modules/virt-viewing-list-of-nodenetworkstate-resources-console.adoc

ousleyp · 2025-08-26T19:39:37Z

modules/virt-viewing-list-of-nodenetworkstate-resources-console.adoc

+
+.Procedure
+. Navigate to *Networking* → *Node Network Configuration*.
+. In the upper-right corner of the page, click the *List* icon.


Accessibility-wise, "upper-right corner" is iffy: https://redhat-documentation.github.io/supplementary-style-guide/#accessibility-visual-info

@ousleyp So how should I point the user to that tiny icon tucked away in, well... the upper-right corner?

networking/k8s_nmstate/k8s-nmstate-observing-node-network-state.adoc

lkladnit · 2025-08-27T06:24:42Z

/lgtm

openshift-ci · 2025-08-27T18:04:45Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2025-08-27T18:19:32Z

@sbeskin-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sbeskin-redhat · 2025-08-27T18:21:35Z

@ousleyp I made the changes. Can we merge the PR now?

ousleyp · 2025-08-28T19:42:04Z

/cherrypick enterprise-4.20

ousleyp · 2025-08-28T19:42:12Z

/cherrypick enterprise-4.19

openshift-cherrypick-robot · 2025-08-28T19:42:51Z

@ousleyp: #97234 failed to apply on top of branch "enterprise-4.20":

Applying: CNV-55995
.git/rebase-apply/patch:122: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
CONFLICT (content): Merge conflict in networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
Removing modules/virt-viewing-network-state-of-node-console.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-55995

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-08-28T19:42:56Z

@ousleyp: #97234 failed to apply on top of branch "enterprise-4.19":

Applying: CNV-55995
.git/rebase-apply/patch:122: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
CONFLICT (content): Merge conflict in networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
Removing modules/virt-viewing-network-state-of-node-console.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-55995

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2025

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2025

upalatucci approved these changes Aug 11, 2025

View reviewed changes

openshift-ci bot assigned lkladnit Aug 11, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025

lkladnit approved these changes Aug 13, 2025

View reviewed changes

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025

ousleyp added CNV Label for all CNV PRs branch/enterprise-4.19 branch/enterprise-4.20 labels Aug 21, 2025

ousleyp added this to the Continuous Release milestone Aug 21, 2025

ousleyp reviewed Aug 21, 2025

View reviewed changes

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2025

sbeskin-redhat force-pushed the CNV_55995_Host_network_configuration_visualization branch 2 times, most recently from da0b423 to 5f523dd Compare August 25, 2025 19:36

sbeskin-redhat force-pushed the CNV_55995_Host_network_configuration_visualization branch from 43493bd to 9d48ac2 Compare August 26, 2025 18:34

ousleyp reviewed Aug 26, 2025

View reviewed changes

networking/k8s_nmstate/k8s-nmstate-observing-node-network-state.adoc Show resolved Hide resolved

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2025

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2025

CNV-55995

c6142d2

sbeskin-redhat force-pushed the CNV_55995_Host_network_configuration_visualization branch from 6526d7c to c6142d2 Compare August 27, 2025 18:05

ousleyp merged commit eb519a9 into openshift:main Aug 28, 2025
2 checks passed

	.. Select the required network state in the Network state part of the section. The default selected state is Up.
	.. Select the required network state in the Network state list. The default selected state is Up.

	.. Select the type of interface in the Type part of the section. The available types are Bridge, Bonding, and Ethernet. The default selected value is Bridge.
	.. Select the type of interface in the Type list. The available types are Bridge, Bonding, and Ethernet. The default selected value is Bridge.

Conversation

sbeskin-redhat commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 6, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 6, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 6, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lkladnit commented Aug 11, 2025

Uh oh!

ctomasko commented Aug 20, 2025

Uh oh!

ousleyp left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ousleyp Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

sbeskin-redhat Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

ousleyp Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

sbeskin-redhat Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sbeskin-redhat commented Aug 25, 2025

Uh oh!

ousleyp commented Aug 25, 2025

Uh oh!

sbeskin-redhat commented Aug 26, 2025

Uh oh!

ousleyp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ousleyp Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

sbeskin-redhat Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lkladnit commented Aug 27, 2025

Uh oh!

openshift-ci bot commented Aug 27, 2025

Uh oh!

openshift-ci bot commented Aug 27, 2025

Uh oh!

sbeskin-redhat commented Aug 27, 2025

Uh oh!

Uh oh!

ousleyp commented Aug 28, 2025

Uh oh!

ousleyp commented Aug 28, 2025

Uh oh!

openshift-cherrypick-robot commented Aug 28, 2025

Uh oh!

openshift-cherrypick-robot commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

sbeskin-redhat commented Aug 6, 2025 •

edited

Loading

openshift-ci-robot commented Aug 6, 2025 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Aug 6, 2025 •

edited

Loading

openshift-ci-robot commented Aug 6, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 6, 2025 •

edited by openshift-ci bot

Loading

ousleyp left a comment •

edited

Loading