Skip to content

Conversation

@gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Aug 15, 2025

OSDOCS-15807 [NETOBSERV] Aditi check: DiscreteHeading

Version(s):
4.12, 4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-15807

Link to docs preview:

QE review:
QE is not required for this PR. This PR addresses issues caught by the Aditi tool related to use of DiscreteHeading.

Additional information:

  • Since not all content applies to every OCP branch, it is possible there will be cherry-pick failures. This will likely apply to release notes since it is 1 assembly file and not all content in release notes is applicable to all OCP branches.
  • I will manually verify content on each breach, and create manual cherry-picks accordingly.
  • Refactoring release notes is being handled by https://issues.redhat.com/browse/OSDOCS-14977

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2025
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 15, 2025
@gwynnemonahan
Copy link
Contributor Author

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 15, 2025
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 15, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 18, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 nits to consider, thanks

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 18, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Aug 18, 2025
@gwynnemonahan
Copy link
Contributor Author

Rebased 08/18/2025 AM

@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 18, 2025
@maxwelldb maxwelldb added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 18, 2025
@maxwelldb maxwelldb self-requested a review August 18, 2025 13:13
@maxwelldb
Copy link
Contributor

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

@openshift-cherrypick-robot

@maxwelldb: once the present PR merges, I will cherry-pick it on top of enterprise-4.12, enterprise-4.14, enterprise-4.15, enterprise-4.16, enterprise-4.17, enterprise-4.18, enterprise-4.19, enterprise-4.20 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maxwelldb maxwelldb removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 18, 2025
@maxwelldb maxwelldb merged commit 125ab21 into openshift:main Aug 19, 2025
2 checks passed
@openshift-cherrypick-robot

@maxwelldb: new pull request created: #97781

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #97782

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #97783

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #97784

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #97785

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #97786

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #97787

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #97788

Details

In response to this:

/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.17
/cherry-pick enterprise-4.18
/cherry-pick enterprise-4.19
/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-merge size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants