OSDOCS-16102 Adding oc adm upgrade recommend to updating with cli

[cbippley]

Version(s): 4.20+

Issue: OSDOCS-16102

Link to docs preview: https://98609--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/updating_a_cluster/updating-cluster-cli.html#update-upgrading-cli_updating-cluster-cli

OKD preview: https://file.corp.redhat.com/cbippley/OSDOCS-15792/updating/updating_a_cluster/updating-cluster-cli.html [must be logged in to the VPN]

QE review:

• QE has approved this change.

Additional information:

[ocpdocs-previewbot]

🤖 Tue Oct 14 20:21:28 - Prow CI generated the docs preview:

https://98609--ocpdocs-pr.netlify.app/
https://98609--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/troubleshooting_updates/gathering-data-cluster-update.html
https://98609--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/understanding_updates/understanding-update-channels-release.html
https://98609--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/updating_a_cluster/migrating-to-multi-payload.html
https://98609--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/updating_a_cluster/updating-cluster-cli.html

[skopacz1]

Left a few comments and hopefully that will help you out. Also, I will quickly define the different conditionals and what they mean, in case it's helpful reference:

• ifdef::condition[] - this means "if condition is defined wherever this module is included, show everything between here and the endif" (i.e. "include in condition assemblies but exclude everywhere else")
• ifndef::condition[] - this means "if condition is not defined wherever this module is included, show everything between here and the endif" (i.e. "exclude from condition assemblies but show everywhere else")
• endif::condition[] - this is like a closing tag, basically "everything past this line is no longer part of either the ifdef or ifndef for condition". You can also have this without a condition specified, like endif::[], and I think it just closes whatever was the most recent ifdef or endif, but it's generally good to specify what condition it should apply to

[skopacz1]

This is the one thing that's sticking out to me right now

[JianLi-RH]

Once we GA recommend, I don't think we need this notification, right? cc @wking

[wking]

Right, this whole file is getting a [removed from assembly] comment up on line 3. I don't understand why we just flag files as removed from assemblies instead of just removing the file, but as far as this pull is concerned, this whitespace removal is just tidying up dead-code, and 🤷, that doesn't hurt or help anything

[JianLi-RH]

cc @dis016 for the status sub-command.

[cbippley]

/retest

[wking]

Looks great! Thanks!

/lgtm

[openshift-ci]

New changes are detected. LGTM label has been removed.

[JianLi-RH]

For the recommend command (excluding precheck), LGTM

[dis016]

@cbippley can we have the example output section for during the upgrade? cc @DavidHurta @wking

[dis016]

/lgtm for status sub-command

[cbippley]

/label merge-review-needed

[jeana-redhat]

Some minor things to look at here. Most important is to fix that formatting error that is causing the steps to restart

/remove-label merge-review-in-progress
/remove-label merge-review-needed

[jeana-redhat]

Typically, we want to refer to "worker" as "compute", unless describing something literal in the code (e.g., a node with role: worker). Seems there is a mix of uses in here, a lot of them probably need to be "worker". Consider adding something that mentions compute as analogous to "worker" near the start since we use "compute" most of the time.

[openshift-ci]

@cbippley: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jeana-redhat]

/cherrypick enterprise-4.20

[openshift-cherrypick-robot]

@jeana-redhat: new pull request created: #100493

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.