CNV-63496: DOC: UI: Live migration to specific node#98824
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@sbeskin-redhat: This pull request references CNV-63496 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/S
|
@sbeskin-redhat: This pull request references CNV-63496 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Looks good to me! |
|
/lgtm |
sbeskin-redhat
force-pushed
the
CNV_63496_UI_Live_migration_to_specific_node
branch
from
67632ea to
2757fd3
Compare
|
/retest |
|
/lgtm |
ousleyp
left a comment
ousleyp
left a comment
There was a problem hiding this comment.
This almost LGTM, but I have a minimalism suggestion for you to consider. :) Thanks!
| . In the *Migrate Virtual Machine to a different Node* dialog box, select either the *Automatically Selected Node* or the *Specific Node* option. | ||
| . If you selected the *Automatically Selected Node* option, click *Migrate Virtual Machine*. | ||
| + | ||
| If you selected the *Specific Node* option, choose the required node from the list displayed in the dialog box and click *Migrate Virtual Machine*. |
There was a problem hiding this comment.
This feels a tad convoluted. Here's a suggestion to simplify it:
| . In the *Migrate Virtual Machine to a different Node* dialog box, select either the *Automatically Selected Node* or the *Specific Node* option. | |
| . If you selected the *Automatically Selected Node* option, click *Migrate Virtual Machine*. | |
| + | |
| If you selected the *Specific Node* option, choose the required node from the list displayed in the dialog box and click *Migrate Virtual Machine*. | |
| . In the *Migrate Virtual Machine to a different Node* dialog box, select either *Automatically Selected Node* or *Specific Node*. | |
| .. If you selected the *Specific Node* option, select a node from the list. | |
| . Click *Migrate Virtual Machine*. |
There was a problem hiding this comment.
@ousleyp Thank you, I made the changes. Could you merge it?
|
New changes are detected. LGTM label has been removed. |
sbeskin-redhat
force-pushed
the
CNV_63496_UI_Live_migration_to_specific_node
branch
from
f639e93 to
c9eb563
Compare
|
@sbeskin-redhat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
LGTM! |
|
/cherrypick enterprise-4.20 |
|
@ousleyp: new pull request created: #99257 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Resolves: https://issues.redhat.com/browse/CNV-63496
CNV-4.20
OCP-4.20
Preview: https://98824--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/live_migration/virt-initiating-live-migration.html#virt-initiating-vm-migration-web_virt-initiating-live-migration