Skip to content

Conversation

@bscott-rh
Copy link
Contributor

@bscott-rh bscott-rh commented Oct 3, 2025

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-16392

Link to docs preview:
AWS
Azure
Azure Stack Hub
GCP
IBM Cloud
Nutanix
Agent based
Bare metal
OpenStack
vSphere

QE review:
Not needed, this is a structural change only.

Additional information:
Continuing the work from #99962
The PR is removing the 3rd column from all of the installation configuration parameter tables, and moving the 3rd column's contents into the 2nd column as "Value: " text. This is essentially because the rendering on the docs site makes these tables unreadable as-is.
There is no new content in the PR, but for full transparency the rearranging was done by Claude on the command line.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2025
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 3, 2025
@bscott-rh bscott-rh force-pushed the restructure-config-params-tables branch from 72b2994 to 993095e Compare October 3, 2025 15:36
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2025
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 3, 2025

🤖 Mon Oct 06 15:57:37 - Prow CI generated the docs preview:
https://100007--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 3, 2025
@bscott-rh bscott-rh force-pushed the restructure-config-params-tables branch from cdc1f01 to c0d9791 Compare October 6, 2025 15:47
@bscott-rh bscott-rh added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

@bscott-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@michaelryanpeter
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 6, 2025
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelryanpeter michaelryanpeter merged commit c5dae2e into openshift:main Oct 6, 2025
2 checks passed
@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.20

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@michaelryanpeter: new pull request created: #100079

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@michaelryanpeter: #100007 failed to apply on top of branch "enterprise-4.19":

Applying: OSDOCS-16392 Updating remaining install config param tables for readability
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-16392 Updating remaining install config param tables for readability

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh bscott-rh removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 branch/enterprise-4.20 size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants