Skip to content

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Oct 6, 2025

Version(s):
4.20

Issue:
https://issues.redhat.com/browse/CNV-55236

Link to docs preview:
https://100076--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/getting_started/virt-using-the-cli-tools.html#hot-plug-and-hot-unplug-commands_virt-using-the-cli-tools

QE review:

  • QE has approved this change.

Additional information:
Due to changes made in #97530 I will need to open additional PRs for older versions (4.17-4.19)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2025

@abrennan89: This pull request references CNV-55236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/CNV-55236

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2025

@abrennan89: This pull request references CNV-55236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/CNV-55236

Link to docs preview:
https://100076--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/getting_started/virt-using-the-cli-tools.html#hot-plug-and-hot-unplug-commands_virt-using-the-cli-tools

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025

@abrennan89: This pull request references CNV-55236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.20

Issue:
https://issues.redhat.com/browse/CNV-55236

Link to docs preview:
https://100076--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/getting_started/virt-using-the-cli-tools.html#hot-plug-and-hot-unplug-commands_virt-using-the-cli-tools

QE review:

  • QE has approved this change.

Additional information:
Due to changes made in #97530 I will need to open additional PRs for older versions (4.17-4.19)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@RoniKishner RoniKishner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from QE

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@abrennan89: This pull request references CNV-55236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.20

Issue:
https://issues.redhat.com/browse/CNV-55236

Link to docs preview:
https://100076--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/getting_started/virt-using-the-cli-tools.html#hot-plug-and-hot-unplug-commands_virt-using-the-cli-tools

QE review:

  • QE has approved this change.

Additional information:
Due to changes made in #97530 I will need to open additional PRs for older versions (4.17-4.19)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielclowers
Copy link
Contributor

LGTM

@abrennan89 abrennan89 merged commit cb69f16 into openshift:main Oct 15, 2025
2 checks passed
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@abrennan89: new pull request created: #100524

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants