OSDOCS-16429 Reducing GCP permissions #100149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
|
🤖 Fri Oct 17 15:05:31 - Prow CI generated the docs preview: |
jianli-wei
suggested changes
Oct 14, 2025
bscott-rh
force-pushed
the
OSDOCS-16429
branch
from
2bc9dcf to
bbb3b20
Compare
jianli-wei
reviewed
Oct 16, 2025
bscott-rh
force-pushed
the
OSDOCS-16429
branch
from
bbb3b20 to
3caf3f6
Compare
jianli-wei
reviewed
Oct 17, 2025
| * `iam.serviceAccountKeys.get` | ||
| * `iam.serviceAccountKeys.list` | ||
| * `iam.serviceAccounts.actAs` | ||
| ** This permission can be limited to act as the control plane and compute service accounts. Alternatively, you may grant the service account that the installation program creates the `iam.serviceAccountUser` role on the control plane and compute service accounts. |
There was a problem hiding this comment.
I guess "you may grant the service account that the installation program creates" should be "you may grant the service account that the installation program uses", is it?
bscott-rh
force-pushed
the
OSDOCS-16429
branch
from
3caf3f6 to
693bcb6
Compare
bscott-rh
added
the
merge-review-needed
mburke5678
added
the
merge-review-in-progress
mburke5678
reviewed
Oct 17, 2025
| ==== | ||
| If you do not supply a service account for control plane nodes in the `install-config.yaml` file, please grant the below permissions to the service account in the host project. If you do not supply a service account for compute nodes in the `install-config.yaml` file, please grant the below permissions to the service account in the host project for cluster destruction. | ||
| If you do not supply a service account for control plane nodes in the `install-config.yaml` file, please grant the below permissions to the service account in the host project. If you do not supply a service account for compute nodes in the `install-config.yaml` file, please grant the below permissions to the service account in the host project for cluster destruction. If you do supply service accounts for control plane and compute nodes, you do not need to grant the below permissions. |
Contributor
There was a problem hiding this comment.
Can I ask you to fix this one? Per ISG: Do not use to indicate a relative location in a document, as in “the information below”
Suggested change
| If you do not supply a service account for control plane nodes in the `install-config.yaml` file, please grant the below permissions to the service account in the host project. If you do not supply a service account for compute nodes in the `install-config.yaml` file, please grant the below permissions to the service account in the host project for cluster destruction. If you do supply service accounts for control plane and compute nodes, you do not need to grant the below permissions. | |
| If you do not supply a service account for control plane nodes in the `install-config.yaml` file, please grant the following permissions to the service account in the host project. If you do not supply a service account for compute nodes in the `install-config.yaml` file, please grant the following permissions to the service account in the host project for cluster destruction. If you do supply service accounts for control plane and compute nodes, you do not need to grant the following permissions. |
bscott-rh
force-pushed
the
OSDOCS-16429
branch
from
693bcb6 to
b7455e9
Compare
|
@bscott-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/cherrypick enterprise-4.20 |
|
@bscott-rh: new pull request created: #100761 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/OSDOCS-16429
Link to docs preview:
https://100149--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-account.html#minimum-required-permissions-ipi-gcp_installing-gcp-account
QE review: