-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-6763: Managing builds for n/w restricted env section #100311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: build-docs-main
Are you sure you want to change the base?
RHDEVDOCS-6763: Managing builds for n/w restricted env section #100311
Conversation
@shivanisathe25: This pull request references RHDEVDOCS-6763 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@shivanisathe25: This pull request references RHDEVDOCS-6763 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b950e86
to
5457739
Compare
@shivanisathe25: This pull request references RHDEVDOCS-6763 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[role="_additional-resources"] | ||
.Additional resources | ||
|
||
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build[Creating a buildah build] | ||
xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildpacks-build[Creating a buildah build] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot have xrefs in modules, this needs to be moved to the assembly
[role="_additional-resources"] | ||
.Additional resources | ||
|
||
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build[Creating a buildah build] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the {context} part of the ID, so it should be fixed (we need to add :context: defined in the assembly where these modules reside:
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build[Creating a buildah build] | |
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build_using-builds[Creating a buildah build] |
|
||
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build[Creating a buildah build] | ||
xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildpacks-build[Creating a buildah build] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, we need to add context part, plus missing asterisk:
xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildpacks-build[Creating a buildah build] | |
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildpacks-build_using-builds[Creating a buildah build] |
@shivanisathe25: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): builds-1.5, 1.6
Issue: https://issues.redhat.com/browse/RHDEVDOCS-6763
Link to docs preview: https://100311--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/managing-builds-in-a-network-restricted-environment
QE review:
Additional information: