Skip to content

Conversation

shivanisathe25
Copy link
Contributor

@shivanisathe25 shivanisathe25 commented Oct 10, 2025

Version(s): builds-1.5, 1.6

Issue: https://issues.redhat.com/browse/RHDEVDOCS-6763

Link to docs preview: https://100311--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/managing-builds-in-a-network-restricted-environment

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2025
@shivanisathe25 shivanisathe25 changed the title created managing builds for n/w restricted env section RHDEVDOCS-6763: Managing builds for n/w restricted env section Oct 13, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2025

@shivanisathe25: This pull request references RHDEVDOCS-6763 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2025

@shivanisathe25: This pull request references RHDEVDOCS-6763 which is a valid jira issue.

In response to this:

Version(s): builds-1.5, 1.6

Issue: https://issues.redhat.com/browse/RHDEVDOCS-6763

Link to docs preview: https://100311--ocpdocs-pr.netlify.app/openshift-builds/latest/configuring/using-builds-in-a-network-restricted-environment.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2025

@shivanisathe25: This pull request references RHDEVDOCS-6763 which is a valid jira issue.

In response to this:

Version(s): builds-1.5, 1.6

Issue: https://issues.redhat.com/browse/RHDEVDOCS-6763

Link to docs preview: https://100311--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/managing-builds-in-a-network-restricted-environment

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2025
Comment on lines 28 to 33
[role="_additional-resources"]
.Additional resources

* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build[Creating a buildah build]
xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildpacks-build[Creating a buildah build]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot have xrefs in modules, this needs to be moved to the assembly

[role="_additional-resources"]
.Additional resources

* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build[Creating a buildah build]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the {context} part of the ID, so it should be fixed (we need to add :context: defined in the assembly where these modules reside:

Suggested change
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build[Creating a buildah build]
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build_using-builds[Creating a buildah build]


* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildah-build[Creating a buildah build]
xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildpacks-build[Creating a buildah build]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we need to add context part, plus missing asterisk:

Suggested change
xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildpacks-build[Creating a buildah build]
* xref:../work_with_builds/managing-builds.adoc#ob-creating-a-buildpacks-build_using-builds[Creating a buildah build]

Copy link

openshift-ci bot commented Oct 17, 2025

@shivanisathe25: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants