Skip to content

Conversation

@lcavalle
Copy link
Contributor

@lcavalle lcavalle commented Oct 12, 2025

Version(s):
4.20

Issue:
TELCODOCS-2100

Link to docs preview:
https://100372--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/advanced_networking/ptp/configuring-ptp.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2025
@lcavalle lcavalle closed this Oct 12, 2025
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 12, 2025
@lcavalle lcavalle reopened this Oct 13, 2025
@lcavalle lcavalle changed the base branch from enterprise-4.20 to main October 13, 2025 08:21
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 13, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 13, 2025

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2025
Copy link
Contributor

@rohennes rohennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start Lluis, some further clarity needed in a few places. This review is outside of the question of how the user gets the customized PTP rpm

@DanyPops
Copy link

This segment

Procedure

  1. Configure the triple port T-BC NIC. See the example below where the PtpConfig resource contains two profiles, one for time transmitter ports (00-tbc-tt) and one to configure all the hardware, the TR port, and ts2phc and phc2sysbprocesses:

to

Procedure

  1. The PtpConfig resource below configures a triple-port T-BC NIC using two distinct profiles. The first profile, 00-tbc-tt, applies to the time transmitter ports. The second, 01-tbc-tr, configures the time receiver port, which includes settings for the hardware as well as the ts2phc and phc2sys processes.

@vitus133 Is the TT / T-BC configuration profile same as the boundary clock configuration, has any changes for this feature? If no, maybe we can note that? "The time receiver configuration is same as a boundary clock configuration"?

@lcavalle lcavalle requested a review from rohennes October 15, 2025 14:28
@vitus133
Copy link

This segment

Procedure

  1. Configure the triple port T-BC NIC. See the example below where the PtpConfig resource contains two profiles, one for time transmitter ports (00-tbc-tt) and one to configure all the hardware, the TR port, and ts2phc and phc2sysbprocesses:

to

Procedure

  1. The PtpConfig resource below configures a triple-port T-BC NIC using two distinct profiles. The first profile, 00-tbc-tt, applies to the time transmitter ports. The second, 01-tbc-tr, configures the time receiver port, which includes settings for the hardware as well as the ts2phc and phc2sys processes.

@vitus133 Is the TT / T-BC configuration profile same as the boundary clock configuration, has any changes for this feature? If no, maybe we can note that? "The time receiver configuration is same as a boundary clock configuration"?

I heard we don't usually reference other topics / config / text in the docs. Although technically correct, we should not say "it is same as that other thing"

@lcavalle
Copy link
Contributor Author

This segment

Procedure

  1. Configure the triple port T-BC NIC. See the example below where the PtpConfig resource contains two profiles, one for time transmitter ports (00-tbc-tt) and one to configure all the hardware, the TR port, and ts2phc and phc2sysbprocesses:

to

Procedure

  1. The PtpConfig resource below configures a triple-port T-BC NIC using two distinct profiles. The first profile, 00-tbc-tt, applies to the time transmitter ports. The second, 01-tbc-tr, configures the time receiver port, which includes settings for the hardware as well as the ts2phc and phc2sys processes.

@vitus133 Is the TT / T-BC configuration profile same as the boundary clock configuration, has any changes for this feature? If no, maybe we can note that? "The time receiver configuration is same as a boundary clock configuration"?

I heard we don't usually reference other topics / config / text in the docs. Although technically correct, we should not say "it is same as that other thing"

Hey @DanyPops given Vitaly's clarification, is that ok to move on? Thanks!

@dpopsuev
Copy link

@lcavalle LGTM!

Copy link
Contributor

@rohennes rohennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Lluis, a few small comments. The main comment is is step 2 repetition of what you just did in step 1?


The unassisted holdover feature enables an Intel E810-XXVDA4T Network Interface Card (NIC), configured as either a Telecom Boundary Clock (T-BC) or a Telecom Time Slave Clock (T-TSC), to maintain highly accurate time synchronization even when the upstream timing signal is lost. This is achieved by relying on the NIC's internal oscillator to enter a stable, controlled drift state.

The `ts2phc` service monitors the `ptp4l` instance bound to the TR port. If the TR port stops operating as the time receiver, if upstream Grandmaster Clock (T-GM) deteriorates in quality or the link disconnects, for example, the system enters holdover mode and reconfigures itself dynamically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization - grandmaster clock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

lcavalle and others added 9 commits October 16, 2025 15:16
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
removing unnecessary step
lcavalle and others added 3 commits October 17, 2025 12:25
Co-authored-by: Shane Lovern <95357210+slovern@users.noreply.github.com>
Co-authored-by: Shane Lovern <95357210+slovern@users.noreply.github.com>
Co-authored-by: Shane Lovern <95357210+slovern@users.noreply.github.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

@lcavalle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@slovern slovern added this to the Planned for 4.20 GA milestone Oct 17, 2025
@slovern slovern merged commit 8c8e594 into openshift:main Oct 17, 2025
2 checks passed
@slovern
Copy link
Contributor

slovern commented Oct 17, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@slovern: new pull request created: #100721

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants