-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TELCODOCS#2100: New holdover feature for #100372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Fri Oct 17 10:33:23 - Prow CI generated the docs preview: |
rohennes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start Lluis, some further clarity needed in a few places. This review is outside of the question of how the user gets the customized PTP rpm
Fixing errors
|
This segment
to
@vitus133 Is the TT / T-BC configuration profile same as the boundary clock configuration, has any changes for this feature? If no, maybe we can note that? "The time receiver configuration is same as a boundary clock configuration"? |
I heard we don't usually reference other topics / config / text in the docs. Although technically correct, we should not say "it is same as that other thing" |
Hey @DanyPops given Vitaly's clarification, is that ok to move on? Thanks! |
|
@lcavalle LGTM! |
rohennes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work Lluis, a few small comments. The main comment is is step 2 repetition of what you just did in step 1?
|
|
||
| The unassisted holdover feature enables an Intel E810-XXVDA4T Network Interface Card (NIC), configured as either a Telecom Boundary Clock (T-BC) or a Telecom Time Slave Clock (T-TSC), to maintain highly accurate time synchronization even when the upstream timing signal is lost. This is achieved by relying on the NIC's internal oscillator to enter a stable, controlled drift state. | ||
|
|
||
| The `ts2phc` service monitors the `ptp4l` instance bound to the TR port. If the TR port stops operating as the time receiver, if upstream Grandmaster Clock (T-GM) deteriorates in quality or the link disconnects, for example, the system enters holdover mode and reconfigures itself dynamically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalization - grandmaster clock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
Co-authored-by: Ronan Hennessy <104497497+rohennes@users.noreply.github.com>
removing unnecessary step
fixing typos
Parenthesis removed
Co-authored-by: Shane Lovern <95357210+slovern@users.noreply.github.com>
Co-authored-by: Shane Lovern <95357210+slovern@users.noreply.github.com>
Co-authored-by: Shane Lovern <95357210+slovern@users.noreply.github.com>
|
@lcavalle: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
@slovern: new pull request created: #100721 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.20
Issue:
TELCODOCS-2100
Link to docs preview:
https://100372--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/advanced_networking/ptp/configuring-ptp.html
QE review:
Additional information: