-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14809: Capacity Reservations in ROSA HCP #100445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-14809: Capacity Reservations in ROSA HCP #100445
Conversation
|
@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
698ab23 to
4404604
Compare
|
@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4404604 to
a598608
Compare
bchandra-ocp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for documenting this feature, the content looks great. I've added in few suggestions for you to consider.
|
@bchandra-ocp Thank you for the feedback and for being attentive to details. I've implemented all the requested changes. Please, let me know if this PR has your LGTM now. |
|
@BraeTroutman or @rafael-azevedo Would appreciate your review of new docs about Capacity Reservations. Docs describe the current state of things and will be further updated as feature development continues. Thank you! |
|
@otikhomi your docs capture the feature well, the main caveats I was looking out for are all there: no autoscaling, no upgrades, and no day2 modifications Thank's for reaching out, I'm going to say |
|
Thanks @BraeTroutman for takin a look amidst other commitment(s). |
|
New changes are detected. LGTM label has been removed. |
6b3c07d to
0263ed4
Compare
jneczypor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I know there are a lot of notes, but you are transitioning to an entirely new product with a different style, so great work! Please reach out with questions.
+1. Great work, Olga. |
e640f0a to
35d0962
Compare
|
Thank you Janelle and Bala for the encouragement. The number of suggestions doesn't scare me, as the vast majority concerns the existing content. In my opinion, improving the existing content is out of scope of my Jira issue, since my task was to add new content. In my previous teams, we'd open a follow-up issue to address that, but I respect that the Managed OpenShift docs team has its own established ways and processes. Whatever the scope, I prefer to implement all the suggested feedback "while we're at it", it's important and helpful feedback, and delivering high-quality docs is the ultimate writers' goal. Janelle, thanks for the amazing attention to detail! I'll implement most of it and leave comments/questions where I have them. Let's make this doc nice together :) |
bchandra-ocp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added confirmation for the following
you can use AWS account to monitor
|
@jneczypor Hi, thanks again for the epic review.
|
bd6f227 to
f2fbfbd
Compare
jneczypor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great to me! Fantastic work and congrats on your first XCMSTRAT!
22174c6 to
b41ab2a
Compare
|
@jneczypor All rebased and squashed now. Please, run a merge review and merge when you have time. |
|
@otikhomi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick enterprise-4.20 |
|
@jneczypor: new pull request created: #100935 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jneczypor: new pull request created: #100936 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |

OSDOCS#14809: Documenting Capacity Reservations on ROSA HCP
Version(s):
4.19+
Issue:
https://issues.redhat.com/browse/OSDOCS-14809
Link to docs preview:
Release notes:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html
CLI reference
rosa-create-machinepool:https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html#rosa-create-machinepool_rosa-managing-objects-cli
Managing compute nodes (Overview of a feature):
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html
(New module) Creating a machine pool with Capacity Reservations using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_capres_rosa-managing-worker-nodes
(Short note that sends to a new Cap Res module) Creating a machine pool using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_rosa-managing-worker-nodes
QE review:
Got 2 technical reviews and approvals.
Additional information: