Skip to content

Conversation

@otikhomi
Copy link
Contributor

@otikhomi otikhomi commented Oct 13, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2025

@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS-14809: Documenting Capacity Reservations on ROSA HCP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14809

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2025
@otikhomi otikhomi force-pushed the OSDOCS-14809-adding-capacity-reservations-rosa-hcp branch from 698ab23 to 4404604 Compare October 13, 2025 23:10
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2025

@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS-14809: Documenting Capacity Reservations on ROSA HCP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14809

Link to docs preview:
Release notes: https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html
CLI reference rosa-create-machinepool: https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html#rosa-create-machinepool_rosa-managing-objects-cli

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2025

@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS-14809: Documenting Capacity Reservations on ROSA HCP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14809

Link to docs preview:
Release notes:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html
CLI reference rosa-create-machinepool:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html#rosa-create-machinepool_rosa-managing-objects-cli
Managing compute nodes (Overview of a feature):
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html
Creating a machine pool using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_rosa-managing-worker-nodes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@otikhomi otikhomi force-pushed the OSDOCS-14809-adding-capacity-reservations-rosa-hcp branch from 4404604 to a598608 Compare October 14, 2025 19:11
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS-14809: Documenting Capacity Reservations on ROSA HCP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14809

Link to docs preview:
Release notes:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html

CLI reference rosa-create-machinepool:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html#rosa-create-machinepool_rosa-managing-objects-cli

Managing compute nodes (Overview of a feature):
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html

(New module) Creating a machine pool with Capacity Reservations using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_capres_rosa-managing-worker-nodes

(Short note that sends to another module) Creating a machine pool using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_rosa-managing-worker-nodes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@bchandra-ocp bchandra-ocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting this feature, the content looks great. I've added in few suggestions for you to consider.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS-14809: Documenting Capacity Reservations on ROSA HCP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14809

Link to docs preview:
Release notes:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html

CLI reference rosa-create-machinepool:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html#rosa-create-machinepool_rosa-managing-objects-cli

Managing compute nodes (Overview of a feature):
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html

(New module) Creating a machine pool with Capacity Reservations using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_capres_rosa-managing-worker-nodes

(Short note that sends to a new Cap Res module) Creating a machine pool using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_rosa-managing-worker-nodes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@otikhomi
Copy link
Contributor Author

@bchandra-ocp Thank you for the feedback and for being attentive to details. I've implemented all the requested changes. Please, let me know if this PR has your LGTM now.

@otikhomi otikhomi requested a review from bchandra-ocp October 15, 2025 22:16
@otikhomi
Copy link
Contributor Author

@BraeTroutman or @rafael-azevedo Would appreciate your review of new docs about Capacity Reservations.

Docs describe the current state of things and will be further updated as feature development continues.

Thank you!

@BraeTroutman
Copy link
Contributor

@otikhomi your docs capture the feature well, the main caveats I was looking out for are all there: no autoscaling, no upgrades, and no day2 modifications

Thank's for reaching out, I'm going to say
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@bchandra-ocp
Copy link

Thanks @BraeTroutman for takin a look amidst other commitment(s).

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2025

New changes are detected. LGTM label has been removed.

@otikhomi otikhomi force-pushed the OSDOCS-14809-adding-capacity-reservations-rosa-hcp branch from 6b3c07d to 0263ed4 Compare October 16, 2025 19:31
@otikhomi otikhomi changed the title OSDOCS-14809: Capacity Reservations on ROSA HCP OSDOCS-14809: Capacity Reservations in ROSA HCP Oct 16, 2025
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I know there are a lot of notes, but you are transitioning to an entirely new product with a different style, so great work! Please reach out with questions.

@bchandra-ocp
Copy link

Great work! I know there are a lot of notes, but you are transitioning to an entirely new product with a different style, so great work! Please reach out with questions.

+1. Great work, Olga.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2025
@otikhomi otikhomi force-pushed the OSDOCS-14809-adding-capacity-reservations-rosa-hcp branch from e640f0a to 35d0962 Compare October 17, 2025 23:27
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2025
@otikhomi
Copy link
Contributor Author

otikhomi commented Oct 17, 2025

Thank you Janelle and Bala for the encouragement.

The number of suggestions doesn't scare me, as the vast majority concerns the existing content.

In my opinion, improving the existing content is out of scope of my Jira issue, since my task was to add new content. In my previous teams, we'd open a follow-up issue to address that, but I respect that the Managed OpenShift docs team has its own established ways and processes.

Whatever the scope, I prefer to implement all the suggested feedback "while we're at it", it's important and helpful feedback, and delivering high-quality docs is the ultimate writers' goal.

Janelle, thanks for the amazing attention to detail! I'll implement most of it and leave comments/questions where I have them. Let's make this doc nice together :)

Copy link

@bchandra-ocp bchandra-ocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added confirmation for the following
you can use AWS account to monitor

@otikhomi
Copy link
Contributor Author

@jneczypor Hi, thanks again for the epic review.
I've implemented most of the changes, there're only 3 places that I haven't marked as resolved. GitHub hid 1 of them though. Will appreciate your thoughts on:

  1. Capacity Blocks ML: thread visible on this Conversation tab.
  2. .Example output: thread visible on the diffs tab.
  3. --subnet parameter: hidden everywhere. Attaching a screenshot so that you don't expand 25 hidden conversations. The text itself is on line 42 in the new module.
Screenshot 2025-10-20 at 2 31 16 PM

@otikhomi otikhomi requested a review from jneczypor October 21, 2025 01:39
@otikhomi otikhomi force-pushed the OSDOCS-14809-adding-capacity-reservations-rosa-hcp branch from bd6f227 to f2fbfbd Compare October 21, 2025 01:44
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 21, 2025

@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS#14809: Documenting Capacity Reservations on ROSA HCP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14809

Link to docs preview:
Release notes:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html

CLI reference rosa-create-machinepool:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html#rosa-create-machinepool_rosa-managing-objects-cli

Managing compute nodes (Overview of a feature):
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html

(New module) Creating a machine pool with Capacity Reservations using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_capres_rosa-managing-worker-nodes

(Short note that sends to a new Cap Res module) Creating a machine pool using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_rosa-managing-worker-nodes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great to me! Fantastic work and congrats on your first XCMSTRAT!

@otikhomi otikhomi changed the title OSDOCS-14809: Capacity Reservations in ROSA HCP OSDOCS#14809: Capacity Reservations in ROSA HCP Oct 21, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 21, 2025
@openshift-ci-robot
Copy link

@otikhomi: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

OSDOCS#14809: Documenting Capacity Reservations on ROSA HCP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14809

Link to docs preview:
Release notes:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html

CLI reference rosa-create-machinepool:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html#rosa-create-machinepool_rosa-managing-objects-cli

Managing compute nodes (Overview of a feature):
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html

(New module) Creating a machine pool with Capacity Reservations using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_capres_rosa-managing-worker-nodes

(Short note that sends to a new Cap Res module) Creating a machine pool using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_rosa-managing-worker-nodes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@otikhomi otikhomi force-pushed the OSDOCS-14809-adding-capacity-reservations-rosa-hcp branch from 22174c6 to b41ab2a Compare October 21, 2025 23:04
@otikhomi
Copy link
Contributor Author

@jneczypor All rebased and squashed now. Please, run a merge review and merge when you have time.
Thank you for your amazing work and help.

@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2025

@otikhomi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@otikhomi otikhomi changed the title OSDOCS#14809: Capacity Reservations in ROSA HCP OSDOCS-14809: Capacity Reservations in ROSA HCP Oct 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2025

@otikhomi: This pull request references OSDOCS-14809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS#14809: Documenting Capacity Reservations on ROSA HCP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14809

Link to docs preview:
Release notes:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html

CLI reference rosa-create-machinepool:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html#rosa-create-machinepool_rosa-managing-objects-cli

Managing compute nodes (Overview of a feature):
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html

(New module) Creating a machine pool with Capacity Reservations using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_capres_rosa-managing-worker-nodes

(Short note that sends to a new Cap Res module) Creating a machine pool using the ROSA CLI:
https://100445--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html#creating_machine_pools_cli_rosa-managing-worker-nodes

QE review:
Got 2 technical reviews and approvals.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2025
@jneczypor jneczypor merged commit 5a90533 into openshift:main Oct 22, 2025
2 checks passed
@jneczypor
Copy link
Contributor

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

@openshift-cherrypick-robot

@jneczypor: new pull request created: #100935

In response to this:

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jneczypor: new pull request created: #100936

In response to this:

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants