-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TELCODOCS-2328 updating RDS files for 4.20 #100502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modules/telco-core-cluster-common-use-model-engineering-considerations.adoc
Outdated
Show resolved
Hide resolved
modules/telco-core-cluster-common-use-model-engineering-considerations.adoc
Outdated
Show resolved
Hide resolved
modules/telco-core-cpu-partitioning-and-performance-tuning.adoc
Outdated
Show resolved
Hide resolved
modules/telco-core-cpu-partitioning-and-performance-tuning.adoc
Outdated
Show resolved
Hide resolved
modules/telco-core-host-firmware-and-boot-loader-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/telco-core-host-firmware-and-boot-loader-configuration.adoc
Outdated
Show resolved
Hide resolved
rohennes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just nits
| During installation, custom `mcp` CRs can be paused along with setting `maxUnavailable` to 100% to improve installation times. | ||
| ==== | ||
|
|
||
| * Orchestration of an upgrade, including OpenShift, day-2 OLM operators and custom configuration can be done using a ClusterGroupUpgrade (CGU) CR containing policies describing these updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Orchestration of an upgrade, including OpenShift, day-2 OLM operators and custom configuration can be done using a ClusterGroupUpgrade (CGU) CR containing policies describing these updates. | |
| * Orchestration of an upgrade, including {product-title}, day-2 OLM operators and custom configuration can be done using a `ClusterGroupUpgrade` (CGU) CR containing policies describing these updates. |
225b06e to
3912fe1
Compare
MarSik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
modules/telco-core-zones.adoc
Outdated
| Engineering Considerations:: | ||
| * Pod drain times can significantly impact node update times. Ensure the workload design allows pods to be drained quickly. | ||
| * PodDisruptionBudgets (PDB) are used to enforce high availability requirements. | ||
| ** To guarantee continuous application availability, a cluster design must utilize enough separate zones to spread the workload's pods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'use' rather than 'utilize'. For more information, see RedHat.TermsErrors.
|
New changes are detected. LGTM label has been removed. |
7e406ee to
d74c078
Compare
| External ODF configuration,`02-ocs-external-storagecluster.yaml`,Defines an OpenShift Container Storage (OCS) storage resource which configures the cluster to use an external storage back end.,No | ||
| External ODF configuration,`odfNS.yaml`,Creates the monitored openshift-storage namespace for the OpenShift Data Foundation Operator.,No | ||
| External ODF configuration,`odfOperGroup.yaml`,"Creates the Operator group in the openshift-storage namespace, allowing the {rh-storage} Operator to watch and manage resources.",No | ||
| External ODF configuration,`odfNS.yaml`,Creates the monitored `openshift-storage` namespace for the OpenShift Data Foundation Operator.,No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{rh-storage}' rather than the plain text product term 'OpenShift Data Foundation', unless your use case is an exception.
| External ODF configuration,`odfNS.yaml`,Creates the monitored openshift-storage namespace for the OpenShift Data Foundation Operator.,No | ||
| External ODF configuration,`odfOperGroup.yaml`,"Creates the Operator group in the openshift-storage namespace, allowing the {rh-storage} Operator to watch and manage resources.",No | ||
| External ODF configuration,`odfNS.yaml`,Creates the monitored `openshift-storage` namespace for the OpenShift Data Foundation Operator.,No | ||
| External ODF configuration,`odfOperGroup.yaml`,"Creates the Operator group in the `openshift-storage` namespace, allowing the OpenShift Data Foundation Operator to watch and manage resources.",No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{rh-storage}' rather than the plain text product term 'OpenShift Data Foundation', unless your use case is an exception.
0e68ca0 to
884aa07
Compare
|
@slovern all ready to be merged |
| External ODF configuration,`02-ocs-external-storagecluster.yaml`,Defines an OpenShift Container Storage (OCS) storage resource which configures the cluster to use an external storage back end.,No | ||
| External ODF configuration,`odfNS.yaml`,Creates the monitored openshift-storage namespace for the OpenShift Data Foundation Operator.,No | ||
| External ODF configuration,`odfOperGroup.yaml`,"Creates the Operator group in the openshift-storage namespace, allowing the {rh-storage} Operator to watch and manage resources.",No | ||
| External ODF configuration,`odfNS.yaml`,Creates the monitored `openshift-storage` namespace for the OpenShift Data Foundation Operator.,No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{rh-storage}' rather than the plain text product term 'OpenShift Data Foundation', unless your use case is an exception.
| External ODF configuration,`odfNS.yaml`,Creates the monitored openshift-storage namespace for the OpenShift Data Foundation Operator.,No | ||
| External ODF configuration,`odfOperGroup.yaml`,"Creates the Operator group in the openshift-storage namespace, allowing the {rh-storage} Operator to watch and manage resources.",No | ||
| External ODF configuration,`odfNS.yaml`,Creates the monitored `openshift-storage` namespace for the OpenShift Data Foundation Operator.,No | ||
| External ODF configuration,`odfOperGroup.yaml`,"Creates the Operator group in the `openshift-storage` namespace, allowing the OpenShift Data Foundation Operator to watch and manage resources.",No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{rh-storage}' rather than the plain text product term 'OpenShift Data Foundation', unless your use case is an exception.
|
@kquinn1204: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
@slovern: new pull request created: #100714 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[TELCODOCS-2328]: Docs update public RDS Core for 4.20
Version(s):4.20
Issue:https://issues.redhat.com/browse/TELCODOCS-2328
Link to docs preview:https://100502--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco-core-rds.html
QE review:
Additional information: